Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python311Packages.stem: enable on Python 3.11 #262813

Merged
merged 2 commits into from
Oct 23, 2023
Merged

python311Packages.stem: enable on Python 3.11 #262813

merged 2 commits into from
Oct 23, 2023

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Oct 22, 2023 •
edited
Loading

Description of changes

fixes #262807

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cc @KiaraGrouwstra

@dotlambda dotlambda requested a review from rhendric October 22, 2023 21:56
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-linux: 11-100 and removed 10.rebuild-linux: 1-10 labels Oct 22, 2023
rhendric
rhendric approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@rhendric rhendric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it builds, I have no objections (though I don't claim any specific knowledge of this package; my previous contribution was a drive-by ZHF fix).

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 23, 2023
@dotlambda
python311Packages.stem: improve expression
96c294e 
Also add myself as maintainer.
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 23, 2023
@dotlambda
Copy link
Member Author

Result of nixpkgs-review pr 262813 run on x86_64-linux 1

20 packages built:
  • electron-cash
  • electron-cash.dist
  • maigret
  • maigret.dist
  • nyx
  • nyx.dist
  • onioncircuits
  • onioncircuits.dist
  • prometheus-tor-exporter
  • python310Packages.stem
  • python310Packages.stem.dist
  • python310Packages.torrequest
  • python310Packages.torrequest.dist
  • python311Packages.stem
  • python311Packages.stem.dist
  • python311Packages.torrequest
  • python311Packages.torrequest.dist
  • qutebrowser
  • qutebrowser.dist
  • sherlock

@dotlambda dotlambda merged commit af80c5f into NixOS:master Oct 23, 2023
9 checks passed
@dotlambda dotlambda deleted the stem-python311 branch November 4, 2023 11:28
@dotlambda dotlambda mentioned this pull request Nov 4, 2023
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt left review comments

@rhendric rhendric rhendric approved these changes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure: qutebrowser
4 participants
@dotlambda @mweinelt @rhendric @delroth