Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging-next] Revert "python3Packages.pyrate-limiter: 2.10.0 -> 3.1.0" #262519

Merged
merged 2 commits into from
Oct 21, 2023
Merged

[staging-next] Revert "python3Packages.pyrate-limiter: 2.10.0 -> 3.1.0" #262519

merged 2 commits into from
Oct 21, 2023

Conversation

yu-re-ka
Copy link
Contributor

@yu-re-ka yu-re-ka commented Oct 21, 2023 •
edited
Loading

Description of changes

All packages currently depending on pyrate-limiter require major version 2.x, and fail with 3.x.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@yu-re-ka
moddb: 0.8.1 -> 0.9.0
0224444
@yu-re-ka
Revert "python3Packages.pyrate-limiter: 2.10.0 -> 3.1.0"
af9b9a1 
This reverts commit 5c6cdad.

All packages currently depending on pyrate-limiter require major version
2.x, and fail with 3.x.
@yu-re-ka yu-re-ka changed the title Pyrate [staging-next] Revert "python3Packages.pyrate-limiter: 2.10.0 -> 3.1.0" Oct 21, 2023
@yu-re-ka yu-re-ka requested review from mweinelt and vcunat October 21, 2023 11:28
@mweinelt
Copy link
Member

Result of nixpkgs-review pr 262519 run on x86_64-linux 1

16 packages built:
  • lutris
  • lutris-free
  • lutris-unwrapped
  • lutris-unwrapped.dist
  • python310Packages.moddb
  • python310Packages.moddb.dist
  • python310Packages.pyrate-limiter
  • python310Packages.pyrate-limiter.dist
  • python310Packages.requests-ratelimiter
  • python310Packages.requests-ratelimiter.dist
  • python311Packages.moddb
  • python311Packages.moddb.dist
  • python311Packages.pyrate-limiter
  • python311Packages.pyrate-limiter.dist
  • python311Packages.requests-ratelimiter
  • python311Packages.requests-ratelimiter.dist

@mweinelt mweinelt merged commit 538bce2 into NixOS:staging-next Oct 21, 2023
6 checks passed
@yu-re-ka yu-re-ka deleted the pyrate branch October 21, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt Awaiting requested review from mweinelt

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yu-re-ka @mweinelt