Mailman fixes for staging-next #260527
Merged
Mailman fixes for staging-next #260527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream has now fixed the tests we were previously disabling ourselves, but in the meantime yet another test has started failing.
mailman is incompatible with importlib-resources 6.x, and upstream have decided to remove the dependency. Fixes: 3c86835 ("python3Packages.importlib-resources: 5.12.0 -> 6.0.1") Link: https://gitlab.com/mailman/mailman/-/issues/1093
At least since e161990 ("mailman: remove docutils input"), we rely on sphinx being a Python library package for our Python version, so that it propagates a compatible docutils. Taking sphinx from the top level therefore won't work right if it's using a different Python version.
If they differ, uwsgi will fail to start, because it won't be able to find the appropriate libraries.
We have Mailman's Python package set pinned to Django 3, which doesn't support Python 3.11.
Hyperkitty's tests fail with 8.x, because it tries and fails to import elastic_transport. There are 7.17.10 and 7.17.11 releases, but for unknown reasons they're not available on PyPI. Link: elastic/elasticsearch-py#2336
Fixes: 37ead19 ("python311Packages.django-allauth: 0.54.0 -> 0.55.2")
github-actions
bot
added
6.topic: python
6.topic: nixos
ofborg
bot
requested review from
m1cr0man,
Ma27,
globin,
zhaofengli and
DerDennisOP
Merged
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
All this is required for the Mailman NixOS test to pass again after #251878.
Many (but not all) of our problems come from the fact that the Mailman Python package set is pinned to Django 3.x, which doesn't support Python 3.11, which is now the default. (Django 3.x will also be EOL soon-ish.) It looks like maybe Mailman's web stuff should support Django 4.x, but I wanted to get it working again first before making big changes like that. I'll look into upgrading to Django 4.x next if I'm able.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)