lib.fileset: Don't use non-reproducible ulimit for stack overflow testing #258080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
ofborg
bot
added
10.rebuild-darwin: 0
4 tasks
|
😢 |
|
Haha, it was a nice idea though! 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
In #255025 I introduced a
libtest that usesulimit -s 100to artificially limit the stack size to test that the stack wouldn't grow arbitrarily large. However in #256417 (review) (where another test that usesulimit -s 100was introduced) @fricklerhandwerk reported a failure relating to this.While the number could be increased to say 200 to make it work, it's probably better to not use this after all. It would be hard to come up with a reliable number.
This work is sponsored by Antithesis ✨
Things done