Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgsi686Linux.libarchive: pull upstream fix for 32-bit systems #257080

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Sep 24, 2023

Without the change pkgsi686Linux.libarchive tests fail as described in libarchive/libarchive#1968

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Without the change `pkgsi686Linux.libarchive` tests fail as described in
libarchive/libarchive#1968
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 24, 2023
Copy link
Contributor

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LeSuisse LeSuisse merged commit cb03289 into NixOS:staging Sep 24, 2023
12 checks passed
@trofi trofi deleted the libarchive-fix-32-bit-tests branch September 24, 2023 22:16
@vcunat vcunat mentioned this pull request Sep 27, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants