Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.flitBuildHook: remove #254309

Merged
merged 68 commits into from
Sep 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
1e704c4
sublime-music: switch to pypaBuildHook
pbsds Sep 9, 2023
e87e6a7
cambrinary: switch to pypaBuildHook
pbsds Sep 9, 2023
c2972f5
offpunk: switch to pypaBuildHook
pbsds Sep 9, 2023
c8466f9
apio: switch to pypaBuildHook
pbsds Sep 9, 2023
1907ffe
python3Packages.aiohttp-remotes: switch to pypaBuildHook
pbsds Sep 9, 2023
71df6d0
python3Packages.aioprocessing: switch to pypaBuildHook
pbsds Sep 9, 2023
0fe33ec
python3Packages.aiorun: switch to pypaBuildHook
pbsds Sep 9, 2023
6eefba1
python3Packages.argon2-cffi: switch to pypaBuildHook
pbsds Sep 9, 2023
9ecbc30
python3Packages.asyncinotify: switch to pypaBuildHook
pbsds Sep 9, 2023
22fb590
python3Packages.asyncstdlib: switch to pypaBuildHook
pbsds Sep 9, 2023
ce95c6a
python3Packages.bash_kernel: switch to pypaBuildHook
pbsds Sep 9, 2023
66164e4
python3Packages.circus: switch to pypaBuildHook
pbsds Sep 9, 2023
de34407
python3Packages.confuse: switch to pypaBuildHook
pbsds Sep 9, 2023
4f3459f
python3Packages.ecs-logging: switch to pypaBuildHook
pbsds Sep 9, 2023
8816729
python3Packages.emborg: switch to pypaBuildHook
pbsds Sep 9, 2023
5871c4c
python3Packages.formbox: switch to pypaBuildHook
pbsds Sep 9, 2023
0956b8a
python3Packages.gidgethub: switch to pypaBuildHook
pbsds Sep 9, 2023
fd22d2c
python3Packages.gspread: switch to pypaBuildHook
pbsds Sep 9, 2023
bb35132
python3Packages.ipwhl: switch to pypaBuildHook
pbsds Sep 9, 2023
9c96f96
python3Packages.jupyter-book: switch to pypaBuildHook
pbsds Sep 9, 2023
64316f7
python3Packages.jupyter-cache: switch to pypaBuildHook
pbsds Sep 9, 2023
b2450a4
python3Packages.loca: switch to pypaBuildHook
pbsds Sep 9, 2023
215bfa6
python3Packages.looseversion: switch to pypaBuildHook
pbsds Sep 9, 2023
a6bfb78
python3Packages.mdformat-admon: switch to pypaBuildHook
pbsds Sep 9, 2023
67d46e4
python3Packages.mdformat-footnote: switch to pypaBuildHook
pbsds Sep 9, 2023
aff7cc7
python3Packages.mdformat-frontmatter: switch to pypaBuildHook
pbsds Sep 9, 2023
8627ba0
python3Packages.mdformat-mkdocs: switch to pypaBuildHook
pbsds Sep 9, 2023
912f2d5
python3Packages.mdformat-simple-breaks: switch to pypaBuildHook
pbsds Sep 9, 2023
08aefa7
python3Packages.mdformat-tables: switch to pypaBuildHook
pbsds Sep 9, 2023
a3310c5
python3Packages.mediafile: switch to pypaBuildHook
pbsds Sep 9, 2023
4f96429
python3Packages.mediapy: switch to pypaBuildHook
pbsds Sep 9, 2023
7494c98
python3Packages.more-itertools: switch to pypaBuildHook
pbsds Sep 9, 2023
abeab7a
python3Packages.myst-nb: switch to pypaBuildHook
pbsds Sep 9, 2023
e827c3d
python3Packages.nestedtext: switch to pypaBuildHook
pbsds Sep 9, 2023
3b82eee
python3Packages.nkdfu: switch to pypaBuildHook
pbsds Sep 9, 2023
853e5e7
python3Packages.parametrize-from-file: switch to pypaBuildHook
pbsds Sep 9, 2023
7f54634
python3Packages.pep440: switch to pypaBuildHook
pbsds Sep 9, 2023
fd63dca
python3Packages.pkgutil-resolve-name: switch to pypaBuildHook
pbsds Sep 9, 2023
2269823
python3Packages.pytest-celery: switch to pypaBuildHook
pbsds Sep 9, 2023
0a45222
python3Packages.pytest-check: switch to pypaBuildHook
pbsds Sep 9, 2023
ebeac39
python3Packages.pytest-cid: switch to pypaBuildHook
pbsds Sep 9, 2023
3ab1cf5
python3Packages.pytest-param-files: switch to pypaBuildHook
pbsds Sep 9, 2023
a624dbc
python3Packages.pytest-raisin: switch to pypaBuildHook
pbsds Sep 9, 2023
6f4a2b3
python3Packages.python_docs_theme: switch to pypaBuildHook
pbsds Sep 9, 2023
3c276bf
python3Packages.qpsolvers: switch to pypaBuildHook
pbsds Sep 22, 2023
6b47bdd
python3Packages.quantiphy-eval: switch to pypaBuildHook
pbsds Sep 9, 2023
47f6661
python3Packages.quantiphy: switch to pypaBuildHook
pbsds Sep 9, 2023
a0b432b
python3Packages.rkm-codes: switch to pypaBuildHook
pbsds Sep 9, 2023
a99e50d
python3Packages.rsskey: switch to pypaBuildHook
pbsds Sep 9, 2023
c5c0a0f
python3Packages.solo-python: switch to pypaBuildHook
pbsds Sep 9, 2023
fc5f9e5
python3Packages.sphinx-design: switch to pypaBuildHook
pbsds Sep 9, 2023
ce73994
python3Packages.sphinx-external-toc: switch to pypaBuildHook
pbsds Sep 9, 2023
8c2b94f
python3Packages.sphinx-hoverxref: switch to pypaBuildHook
pbsds Sep 9, 2023
1951f90
python3Packages.sphinx-inline-tabs: switch to pypaBuildHook
pbsds Sep 9, 2023
c7161dc
python3Packages.sphinx-mdinclude: switch to pypaBuildHook
pbsds Sep 9, 2023
3e53c1f
python3Packages.sphinx-notfound-page: switch to pypaBuildHook
pbsds Sep 9, 2023
7040fb7
python3Packages.sphinx-pytest: switch to pypaBuildHook
pbsds Sep 9, 2023
37303b4
python3Packages.threadpoolctl: switch to pypaBuildHook
pbsds Sep 9, 2023
3bdd890
python3Packages.tidyexc: switch to pypaBuildHook
pbsds Sep 9, 2023
e5d07ab
python3Packages.tinycss2: switch to pypaBuildHook
pbsds Sep 9, 2023
2fdcc59
python3Packages.turnt: switch to pypaBuildHook
pbsds Sep 9, 2023
4fcabcd
python3Packages.zeversolarlocal: switch to pypaBuildHook
pbsds Sep 9, 2023
f9f04e7
brutalmaze: switch to pypaBuildHook
pbsds Sep 9, 2023
3a2a8ad
spf-engine: switch to pypaBuildHook
pbsds Sep 9, 2023
f8fd7de
pynitrokey: switch to pypaBuildHook
pbsds Sep 9, 2023
c2ab458
trueseeing: switch to pypaBuildHook
pbsds Sep 9, 2023
175f10a
poetry2nix: remove flitBuildHook
pbsds Sep 9, 2023
bdda7b0
python3Packages.flitBuildHook: remove
pbsds Sep 9, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion doc/languages-frameworks/python.section.md
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,6 @@ are used in `buildPythonPackage`.
with the `eggInstallHook`
- `eggBuildHook` to skip building for eggs.
- `eggInstallHook` to install eggs.
- `flitBuildHook` to build a wheel using `flit`.
- `pipBuildHook` to build a wheel using `pip` and PEP 517. Note a build system
(e.g. `setuptools` or `flit`) should still be added as `nativeBuildInput`.
- `pypaBuildHook` to build a wheel using
Expand Down
2 changes: 2 additions & 0 deletions nixos/doc/manual/release-notes/rl-2311.section.md
Original file line number Diff line number Diff line change
Expand Up @@ -336,4 +336,6 @@ The module update takes care of the new config syntax and the data itself (user
can automatically format the root device by setting
`virtualisation.fileSystems."/".autoFormat = true;`.

- `python3.pkgs.flitBuildHook` has been removed. Use `flit-core` and `format = "pyproject"` instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comment underneath the headline

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please elaborate

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog sections should be randomly sorted and not appeneded


- The `electron` packages now places its application files in `$out/libexec/electron` instead of `$out/lib/electron`. Packages using electron-builder will fail to build and need to be adjusted by changing `lib` to `libexec`.
3 changes: 2 additions & 1 deletion pkgs/applications/audio/sublime-music/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ in
python.pkgs.buildPythonApplication rec {
pname = "sublime-music";
version = "0.12.0";
format = "flit";
format = "pyproject";

src = fetchFromGitHub {
owner = "sublime-music";
Expand All @@ -54,6 +54,7 @@ python.pkgs.buildPythonApplication rec {
};

nativeBuildInputs = [
python.pkgs.flit-core
gobject-introspection
wrapGAppsHook
];
Expand Down
7 changes: 6 additions & 1 deletion pkgs/applications/misc/cambrinary/default.nix
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
{ lib
, buildPythonApplication
, fetchFromGitHub
, flit
, aiohttp
, beautifulsoup4
}:

buildPythonApplication rec {
pname = "cambrinary";
version = "unstable-2023-07-16";
format = "flit";
format = "pyproject";

src = fetchFromGitHub {
owner = "xueyuanl";
Expand All @@ -17,6 +18,10 @@ buildPythonApplication rec {
hash = "sha256-wDcvpKAY/6lBjO5h3qKH3+Y2G2gm7spcKCXFMt/bAtE=";
};

nativeBuildInputs = [
flit
];

propagatedBuildInputs = [
aiohttp
beautifulsoup4
Expand Down
4 changes: 2 additions & 2 deletions pkgs/applications/networking/browsers/offpunk/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ in
python3Packages.buildPythonPackage rec {
pname = "offpunk";
version = "1.10";
format = "flit";
format = "pyproject";

disabled = python3Packages.pythonOlder "3.7";

Expand All @@ -43,7 +43,7 @@ python3Packages.buildPythonPackage rec {
hash = "sha256-+jGKPPnKZHn+l6VAwuae6kICwR7ymkYJjsM2OHQAEmU=";
};

nativeBuildInputs = [ installShellFiles ];
nativeBuildInputs = [ python3Packages.flit-core installShellFiles ];
propagatedBuildInputs = otherDependencies ++ pythonDependencies;

postInstall = ''
Expand Down
7 changes: 6 additions & 1 deletion pkgs/development/embedded/fpga/apio/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,14 @@
, scons
, setuptools
, tinyprog
, flit-core
, pytestCheckHook
}:

buildPythonApplication rec {
pname = "apio";
version = "0.8.1";
format = "flit";
format = "pyproject";

src = fetchFromGitHub {
owner = "FPGAwars";
Expand Down Expand Up @@ -47,6 +48,10 @@ buildPythonApplication rec {
'version = semantic_version.Version(pkg_version.replace(".dev", "-dev"))'
'';

nativeBuildInputs = [
flit-core
];

propagatedBuildInputs = [
click
semantic-version
Expand Down
9 changes: 0 additions & 9 deletions pkgs/development/interpreters/python/hooks/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,6 @@ in {
propagatedBuildInputs = [ ];
} ./egg-unpack-hook.sh) {};

flitBuildHook = callPackage ({ makePythonHook, flit }:
makePythonHook {
name = "flit-build-hook";
propagatedBuildInputs = [ flit ];
substitutions = {
inherit pythonInterpreter;
};
} ./flit-build-hook.sh) {};

pipBuildHook = callPackage ({ makePythonHook, pip, wheel }:
makePythonHook {
name = "pip-build-hook.sh";
Expand Down
15 changes: 0 additions & 15 deletions pkgs/development/interpreters/python/hooks/flit-build-hook.sh

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
, namePrefix
, update-python-libraries
, setuptools
, flitBuildHook
, pypaBuildHook
, pypaInstallHook
, pythonCatchConflictsHook
Expand Down Expand Up @@ -90,7 +89,6 @@
# Several package formats are supported.
# "setuptools" : Install a common setuptools/distutils based package. This builds a wheel.
# "wheel" : Install from a pre-compiled wheel.
# "flit" : Install a flit package. This builds a wheel.
# "pyproject": Install a package using a ``pyproject.toml`` file (PEP517). This builds a wheel.
# "egg": Install a package from an egg.
# "other" : Provide your own buildPhase and installPhase.
Expand Down Expand Up @@ -122,7 +120,7 @@ let
else
"setuptools";

withDistOutput = lib.elem format' ["pyproject" "setuptools" "flit" "wheel"];
withDistOutput = lib.elem format' ["pyproject" "setuptools" "wheel"];

name_ = name;

Expand Down Expand Up @@ -222,8 +220,6 @@ let
unzip
] ++ lib.optionals (format' == "setuptools") [
setuptoolsBuildHook
] ++ lib.optionals (format' == "flit") [
flitBuildHook
] ++ lib.optionals (format' == "pyproject") [(
if isBootstrapPackage then
pypaBuildHook.override {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,10 @@

, ... } @ attrs:

assert lib.assertMsg (format != "flit") "flit is not a supported Python 2 format";

let
inherit (python) stdenv;

withDistOutput = lib.elem format ["pyproject" "setuptools" "flit" "wheel"];
withDistOutput = lib.elem format ["pyproject" "setuptools" "wheel"];

name_ = name;

Expand Down Expand Up @@ -171,7 +169,7 @@ let
nativeBuildInputs = [
python
wrapPython
ensureNewerSourcesForZipFilesHook # move to wheel installer (pip) or builder (setuptools, flit, ...)?
ensureNewerSourcesForZipFilesHook # move to wheel installer (pip) or builder (setuptools, ...)?
pythonRemoveTestsDirHook
] ++ lib.optionals catchConflicts [
pythonCatchConflictsHook
Expand Down
7 changes: 6 additions & 1 deletion pkgs/development/python-modules/aiohttp-remotes/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
, aiohttp
, buildPythonPackage
, fetchPypi
, flit
, pytest-aiohttp
, pytestCheckHook
, pythonOlder
Expand All @@ -11,7 +12,7 @@
buildPythonPackage rec {
pname = "aiohttp-remotes";
version = "1.2.0";
format = "flit";
format = "pyproject";

disabled = pythonOlder "3.6";

Expand All @@ -21,6 +22,10 @@ buildPythonPackage rec {
sha256 = "f95c3a6be5e2de746a85ce9af49ec548da6db8378d7e81bb171ec77b13562a6c";
};

nativeBuildInputs = [
flit
];

propagatedBuildInputs = [
aiohttp
] ++ lib.optionals (pythonOlder "3.7") [
Expand Down
2 changes: 1 addition & 1 deletion pkgs/development/python-modules/aioprocessing/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
buildPythonPackage rec {
pname = "aioprocessing";
version = "2.0.1";
format = "flit";
format = "pyproject";

disabled = pythonOlder "3.5";

Expand Down
16 changes: 15 additions & 1 deletion pkgs/development/python-modules/aiorun/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
, buildPythonPackage
, fetchFromGitHub
, pythonOlder
, fetchpatch
, flit-core
, pygments
, pytestCheckHook
, uvloop
Expand All @@ -10,7 +12,7 @@
buildPythonPackage rec {
pname = "aiorun";
version = "2023.7.2";
format = "flit";
format = "pyproject";

disabled = pythonOlder "3.7";

Expand All @@ -21,6 +23,18 @@ buildPythonPackage rec {
hash = "sha256-3AGsT8IUNi5SZHBsBfd7akj8eQ+xb0mrR7ydIr3T8gs=";
};

patches = [
# Raise flit-core version constrains
(fetchpatch { # https://github.com/cjrh/aiorun/pull/85
url = "https://github.com/cjrh/aiorun/commit/a0c027ea331167712738e35ca70fefcd794e16d5.patch";
hash = "sha256-M1rcrkdFcoFa3IncPnJaRhnXbelyk56QnMGtmgB6bvk=";
})
];

nativeBuildInputs = [
flit-core
];

propagatedBuildInputs = [
pygments
];
Expand Down
7 changes: 6 additions & 1 deletion pkgs/development/python-modules/argon2-cffi/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
, wheel
, buildPythonPackage
, fetchPypi
, flit-core
, isPy3k
, lib
, stdenv
Expand All @@ -15,13 +16,17 @@
buildPythonPackage rec {
pname = "argon2-cffi";
version = "21.3.0";
format = "flit";
format = "pyproject";

src = fetchPypi {
inherit pname version;
sha256 = "d384164d944190a7dd7ef22c6aa3ff197da12962bd04b17f64d4e93d934dba5b";
};

nativeBuildInputs = [
flit-core
];

propagatedBuildInputs = [ cffi six argon2-cffi-bindings ]
++ lib.optional (!isPy3k) enum34;

Expand Down
7 changes: 6 additions & 1 deletion pkgs/development/python-modules/asyncinotify/default.nix
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
{ lib
, buildPythonPackage
, fetchFromGitLab
, flit-core
, python
}:

buildPythonPackage rec {
pname = "asyncinotify";
version = "4.0.2";
format = "flit";
format = "pyproject";

src = fetchFromGitLab {
owner = "Taywee";
Expand All @@ -16,6 +17,10 @@ buildPythonPackage rec {
hash = "sha256-Q7b406UENCmD9SGbaml+y2YLDi7VLZBmDkYMo8CLuVw=";
};

nativeBuildInputs = [
flit-core
];

checkPhase = ''
${python.pythonForBuild.interpreter} ${src}/test.py
'';
Expand Down
7 changes: 6 additions & 1 deletion pkgs/development/python-modules/asyncstdlib/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,15 @@
, buildPythonPackage
, fetchFromGitHub
, typing-extensions
, flit-core
, pytestCheckHook
, pythonOlder
}:

buildPythonPackage rec {
pname = "asyncstdlib";
version = "3.10.8";
format = "flit";
format = "pyproject";

disabled = pythonOlder "3.7";

Expand All @@ -20,6 +21,10 @@ buildPythonPackage rec {
hash = "sha256-7HQFyIR+NWRzbFkzkZiuEQotZfCXpCzrWfWIFg1lWv4=";
};

nativeBuildInputs = [
flit-core
];

propagatedBuildInputs = [
typing-extensions
];
Expand Down
5 changes: 4 additions & 1 deletion pkgs/development/python-modules/bash_kernel/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
, buildPythonPackage
, fetchPypi
, fetchpatch
, flit-core
, ipykernel
, isPy27
, python
Expand All @@ -12,7 +13,7 @@
buildPythonPackage rec {
pname = "bash_kernel";
version = "0.9.0";
format = "flit";
format = "pyproject";
disabled = isPy27;

src = fetchPypi {
Expand All @@ -33,6 +34,8 @@ buildPythonPackage rec {
--replace "\"bash\"" "'${bash}/bin/bash'"
'';

nativeBuildInputs = [ flit-core ];

propagatedBuildInputs = [ ipykernel pexpect ];

# no tests
Expand Down
Loading