pitivi: pass hicolor-theme to fix missing icons #254279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkechiShiro
force-pushed
the
pitivi-fix-hicolor-theme
branch
from
eb6dcfa to
89a9a0f
Compare
wegank
reviewed
Sep 9, 2023
ofborg
bot
added
11.by: package-maintainer
wegank
force-pushed
the
pitivi-fix-hicolor-theme
branch
from
5b90ca4 to
f37f1d9
Compare
* fix indentation
AkechiShiro
force-pushed
the
pitivi-fix-hicolor-theme
branch
from
f37f1d9 to
dc0f76e
Compare
|
This should be ready to get merged @wegank, thanks for your help |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review-december/1711/16 |
|
Yeah, the aarch64-linux failure looks irrelevant. |
|
I noticed I made a little mistake, I added myself to the maintainers but without you know separating the commit, was that okay? |
|
It's OK for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Pitivi seems to not be compatible with Adwaita and requires hicolor-theme-icons at runtime.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)