Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgresql: default to v15 in 23.11 #254268

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

nbdd0121
Copy link
Contributor

@nbdd0121 nbdd0121 commented Sep 9, 2023

Description of changes

Change the default postgres version from 14 to 15 in release 23.11.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 9, 2023
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Sep 9, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 9, 2023
Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs a change in all-packages.nix to change the default postgresql and postgresqlPackages expressions.

EDIT: Specifically, look here — https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/all-packages.nix#L27276-L27289

Please swap 14 and 15, and make sure the entries are otherwise sorted as they are now.

@natsukium
Copy link
Member

@ajs124 ajs124 marked this pull request as draft September 10, 2023 13:07
@nbdd0121 nbdd0121 changed the base branch from master to staging September 10, 2023 13:07
@ajs124 ajs124 marked this pull request as ready for review September 10, 2023 13:07
@kirillrdy
Copy link
Member

@nbdd0121 please rebase and fix merge conflicts

@nbdd0121 nbdd0121 force-pushed the postgres-state-version branch from 23ff9d7 to d3e28a4 Compare September 15, 2023 10:21
@nbdd0121
Copy link
Contributor Author

Rebased

@kirillrdy
Copy link
Member

@nbdd0121 looks like conflict again

@kirillrdy
Copy link
Member

how about making 16 default for 23.11 ?

@nbdd0121
Copy link
Contributor Author

I think psql 16 is too new for 23.11 release. IIUC timescaledb doesn't yet support psql 16. Probably would be better to wait a bit before making it the default.

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 19, 2023
@nbdd0121 nbdd0121 force-pushed the postgres-state-version branch from d3e28a4 to 098c158 Compare September 19, 2023 14:45
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 19, 2023
@delroth delroth added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Sep 21, 2023
@yu-re-ka yu-re-ka merged commit e037977 into NixOS:staging Sep 27, 2023
6 checks passed
@leona-ya
Copy link
Member

leona-ya commented Oct 1, 2023

I'm sorry to come up with this now, i haven't seen this PR before it got merged. I think users will probably get confused that services.postgresql.ensureUsers/ensureDatabases will not "just" work (see #216989 for context). imo we should use postgresql 14 for less confusion (it's okay if you feel different)

@SuperSandro2000
Copy link
Member

We have 3 PRs to choose from to fix this: #203474 , #252071, #255961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 12.approvals: 2 This PR was reviewed and approved by two reputable people 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants