-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
postgresql: default to v15 in 23.11 #254268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also needs a change in all-packages.nix
to change the default postgresql
and postgresqlPackages
expressions.
EDIT: Specifically, look here — https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/all-packages.nix#L27276-L27289
Please swap 14 and 15, and make sure the entries are otherwise sorted as they are now.
f79dca3
to
23ff9d7
Compare
This PR should go to |
@nbdd0121 please rebase and fix merge conflicts |
23ff9d7
to
d3e28a4
Compare
Rebased |
@nbdd0121 looks like conflict again |
how about making 16 default for 23.11 ? |
I think psql 16 is too new for 23.11 release. IIUC timescaledb doesn't yet support psql 16. Probably would be better to wait a bit before making it the default. |
d3e28a4
to
098c158
Compare
I'm sorry to come up with this now, i haven't seen this PR before it got merged. I think users will probably get confused that |
Description of changes
Change the default postgres version from 14 to 15 in release 23.11.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)