cc-wrapper: Account for NIX_LDFLAGS and NIX_CFLAGS_LINK in linkType #253116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, pkgsStatic.pkgsLLVM.hello fails with segfaulting binaries because of the issue described at [0]. In summary, llvm's linker has a different behaviour to GCC's when supplied with both -static and -Wl,-dynamic-linker=...; GCC copes with it, but LLVM produces a binary which segfaults on startup. It appears to be necessary to omit the dynamic linker in this case. nixpkgs' static adaptor passes -static via NIX_CFLAGS_LINK which was not accounted for prior to this commit in the checkLinkType logic. For good measure I put the other NIX_ flags affecting link in the same logic. Additionally, $NIX_CFLAGS_LINK_@suffixSalt@ is not available until later than it was originally set, so set $linkType close to its point of use. I checked for earlier uses by studying the shell trace output and couldn't find any. [0] NixOS#111010 (comment) Signed-off-by: Peter Waller <[email protected]>
|
cc @rrbutani for when you're back. |
ofborg
bot
added
10.rebuild-darwin-stdenv
|
Ping @rrbutani and others, can we progress this one? |
alyssais
reviewed
Sep 16, 2023
delroth
added
the
12.approvals: 1
Artturin
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
pkgsStatic.pkgsLLVM.bash built and launched
There were errors like this, but they were there before too so not a regression.
bash> x86_64-unknown-linux-musl-ld: error: undefined symbol: termsig_handler
bash> >>> referenced by head.c:146
bash> >>> head.o:(head_builtin)
bash> >>> referenced by head.c:82
bash> >>> head.o:(file_head)
bash> >>> referenced by head.c:88
bash> >>> head.o:(file_head)
bash> x86_64-unknown-linux-musl-ld: error: undefined symbol: interrupt_state
bash> >>> referenced by head.c:146
bash> >>> head.o:(head_builtin)
bash> >>> referenced by head.c:0
bash> >>> head.o:(file_head)
bash> x86_64-unknown-linux-musl-ld: error: undefined symbol: throw_to_top_level
bash> >>> referenced by head.c:146
bash> >>> head.o:(head_builtin)
bash> >>> referenced by head.c:82
bash> >>> head.o:(file_head)
bash> >>> referenced by head.c:88
bash> >>> head.o:(file_head)
bash> x86_64-unknown-linux-musl-ld: error: undefined symbol: builtin_help
bash> >>> referenced by head.c:122
bash> >>> head.o:(head_builtin)
bash> x86_64-unknown-linux-musl-ld: error: undefined symbol: builtin_usage
bash> >>> referenced by head.c:124
bash> >>> head.o:(head_builtin)
bash> clang-11: error: linker command failed with exit code 1 (use -v to see invocation)
bash> make[1]: *** [Makefile:169: tty] Error 1
bash> clang-11: make[1]: *** [Makefile:175: tee] Error 1
bash> error: linker command failed with exit code 1 (use -v to see invocation)
Probably something to do with the shared flag
bash> x86_64-unknown-linux-musl-clang -shared -Wl,-soname,head -o head head.o
|
In case anybody ends up bisecting to here, your problem might be #269429, which was not caused by this PR, just made more prominent by it. |
rrbutani
added
the
6.topic: llvm/clang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Without this, pkgsStatic.pkgsLLVM.hello fails with segfaulting binaries
because of the issue described at [0].
In summary, llvm's linker has a different behaviour to GCC's when
supplied with both -static and -Wl,-dynamic-linker=...; GCC copes with
it, but LLVM produces a binary which segfaults on startup. It appears to
be necessary to omit the dynamic linker in this case.
nixpkgs' static adaptor passes -static via NIX_CFLAGS_LINK which was not
accounted for prior to this commit in the checkLinkType logic. For good
measure I put the other NIX_ flags affecting link in the same logic.
Additionally, $NIX_CFLAGS_LINK_@suffixSalt@ is not available until later
than it was originally set, so set $linkType close to its point of use.
I checked for earlier uses by studying the shell trace output and
couldn't find any.
[0] #111010 (comment)
Signed-off-by: Peter Waller [email protected]
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)