-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "qutebrowser: 2.5.4 -> 3.0.0"" #251668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also: #251660 (comment) |
I don't understand what you mean by this. |
Downgrading from pyqt6-webengine to pyqtwebengine leads to data loss afaik. We can't afford to ship the downgrade to nixos-unstable. Let's discuss properly taking doing any action. |
Qt5's webengine can't deal with the SQLite database after migrations were applied |
Hence I'm merging this now and ask you to wait for comments before making changes, just like @rnhmjoj should have waited before merging #250171. |
We have to use Qt6 by default now that some people's databases were migrated over.
No
You get a warning, and even if you ignore it it's just the cookies.
Rules for thee but not for me.... |
Not true. I'm only undoing something that was done just a second ago so we can have a discussion before (potentially) making that change again.
Exactly, data loss. If we want the warning to be effective at all we'd at least have to tell people about the existence of |
What next, we remove If anything, the silent data loss occured when #250171 silently caused an irreversible upgrade to peoples' cookies. The longer we leave that on Frankly it smells like stalling as a negotiating tactic while claiming that time is on your side. That's pretty dishonest. If this is the big deal that you claim it is why didn't #250171 even touch the release notes? |
The sad news is that #250171 has already made it to nixos-unstable. I think it shouldn't have been merged this fast but we can't do anything about that now.
It's not. I just want to have a discussion first. |
That is a really sleazy attitude.
No you don't! You've declared that nothing can be done. You're stalling to deliberately increase the number of people who've been silently upgraded. |
I don't mean that we can't revert the change. I just mean that some people will inevitably end up with a downgrade if we do. |
Nothing can be done about a Qt6 version having made it to nixos-unstable. Stop misinterpreting me on purpose. |
These accusations don't get us further. I'd rather discuss options. Maybe Matrix is the best place for that? |
Schema migrations are to be expected when upgrading packages. Assuming this is a package upgrade, this is a schema migration, and not data loss. Reverting schema migrations / making them forward+backward compatible is left as an issue for upstream to solve, we can't handle every schema out there. Upstream made this the current version, maintainers upgraded, schemas got migrated. No data loss. |
Reverts #251660
A downgrade would lead to data loss.