Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python310Packages.jmp: unstable-2021-10-03 -> 0.0.4 #249146

Merged
merged 1 commit into from
Aug 17, 2023
Merged

python310Packages.jmp: unstable-2021-10-03 -> 0.0.4 #249146

merged 1 commit into from
Aug 17, 2023

Conversation

natsukium
Copy link
Member

Diff: google-deepmind/jmp@4b94370...v0.0.4

Changelog: https://github.com/deepmind/jmp/releases/tag/v0.0.4

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@natsukium natsukium mentioned this pull request Aug 14, 2023
Merged
12 tasks
@natsukium
Copy link
Member Author

@ofborg build python311Packages.jmp

@natsukium
Copy link
Member Author

Result of nixpkgs-review pr 249146 run on x86_64-linux 1

12 packages marked as broken and skipped:
  • python310Packages.distrax
  • python310Packages.distrax.dist
  • python310Packages.rlax
  • python310Packages.rlax.dist
  • python311Packages.distrax
  • python311Packages.distrax.dist
  • python311Packages.elegy
  • python311Packages.elegy.dist
  • python311Packages.rlax
  • python311Packages.rlax.dist
  • python311Packages.treex
  • python311Packages.treex.dist
10 packages failed to build:
  • python310Packages.dm-haiku
  • python310Packages.dm-haiku.dist
  • python310Packages.dm-haiku.testsout
  • python310Packages.elegy
  • python310Packages.elegy.dist
  • python310Packages.treex
  • python310Packages.treex.dist
  • python311Packages.dm-haiku
  • python311Packages.dm-haiku.dist
  • python311Packages.dm-haiku.testsout
4 packages built:
  • python310Packages.jmp
  • python310Packages.jmp.dist
  • python311Packages.jmp
  • python311Packages.jmp.dist

@natsukium
Copy link
Member Author

python310Packages.{elegy,treex} will be marked as broken in #249149
python310Packages.dm-haiku will be fixed in #249140

@ofborg ofborg bot requested a review from ndl August 14, 2023 16:48
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Aug 14, 2023
tjni
tjni approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@tjni tjni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the build on Python 3.11. Thank you!

@tjni tjni merged commit ebcaf19 into NixOS:master Aug 17, 2023
@natsukium natsukium deleted the jmp/update branch August 17, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjni tjni tjni approved these changes

@ndl ndl Awaiting requested review from ndl

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natsukium @tjni