Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt6Packages.qt6gtk2: init at 0.2 #245571

Merged
merged 2 commits into from
Jul 27, 2023
Merged

qt6Packages.qt6gtk2: init at 0.2 #245571

merged 2 commits into from
Jul 27, 2023

Conversation

Misterio77
Copy link
Member

@Misterio77 Misterio77 commented Jul 26, 2023 •
edited
Loading

Description of changes

Add qt6gtk2, plugins that help make qt6 apps use gtk2 theming.

I've also set qt's NixOS module to have qt6gtk2 available when using platformTheme gtk2.

Fixes #244895

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 26, 2023
This was referenced Jul 26, 2023
Merged
Closed
@Misterio77
Copy link
Member Author

Misterio77 commented Jul 26, 2023 •
edited
Loading

While working on this, I noticed /lib/qt-6/plugins is only added to environment.profileRelativeSessionVariables when qt.enable = true (#211003).

I think this should always be the case; adding qt6 plugins to my environment (e.g. through home-manager) should make them work, similarly to qt{4,5} and GTK{2,3,4}.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jul 26, 2023
@Misterio77
qt6Packages.qt6gtk2: init at 0.2
415cd92
@Misterio77
nixos/qt: install qt6gtk2 when using gtk2
ff8b699 
Now qt6 apps are correctly themed when using platformTheme gtk2.
@Misterio77 Misterio77 requested a review from thiagokokada July 27, 2023 18:40
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Jul 27, 2023
@thiagokokada thiagokokada merged commit a6096c2 into NixOS:master Jul 27, 2023
@Misterio77 Misterio77 deleted the qt6gtk2 branch July 27, 2023 21:44
@Misterio77 Misterio77 mentioned this pull request Sep 18, 2023
Open
@mobsenpai mobsenpai mentioned this pull request Oct 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GTK/Qt theme not working
2 participants
@Misterio77 @thiagokokada