rust: add isMips64n32 to badPlatforms #245304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust is not yet able to target the n32 ABI on mips64. Let's add `isMips64n32` to the `meta.badPlatforms` of all derivations created by buildRustCrate. I use this to automatically detect which packages on my system can be built for n32 (almost all of them) and build those using n32, and the few packages (mainly those that depend on boost or rust) that can't for n64.
ghost
requested review from
Rust is not yet able to target the n32 ABI on mips64. Let's add `isMips64n32` to the `meta.badPlatforms` of all derivations created by buildRustPackage. I use this to automatically detect which packages on my system can be built for n32 (almost all of them) and build those using n32, and the few packages (mainly those that depend on boost or rust) that can't for n64.
ghost
changed the title
ofborg
bot
added
10.rebuild-darwin: 0
ghost
mentioned this pull request
12 tasks
|
If there are no objections I intend to merge this. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Rust is not yet able to target the n32 ABI on mips64.
Let's add
isMips64n32to themeta.badPlatformsof all derivations created bybuildRustCrateandbuildRustPackage.I use this to automatically detect which packages on my system can be built for n32 (almost all of them) and build those using n32, and the few packages (mainly those that depend on boost or rust) that can't for n64.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)