Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mosquitto: fix bug with firefox wss http/2 #244604

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Conversation

rskew
Copy link
Contributor

@rskew rskew commented Jul 21, 2023

Firefox has a bug preventing websockets being created with a server that uses http/2. Building libwebsockets without http/2 support fixes this issue for mosquitto.
See eclipse-mosquitto/mosquitto#1211 (comment)

Description of changes

Override libwebsockets to be built without HTTP/2 support for mosquitto

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Firefox has a bug preventing websockets being created with
a server that uses http/2. Building libwebsockets without
http/2 support fixes this issue for mosquitto.
See eclipse-mosquitto/mosquitto#1211 (comment)
@kirillrdy
Copy link
Member

Result of nixpkgs-review pr 244604 run on aarch64-linux 1

4 packages built:
  • collectd
  • domoticz
  • mosquitto
  • owntracks-recorder

@peterhoeg peterhoeg merged commit 7687b84 into NixOS:master Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants