nixosTests.nixos-rebuild-specialisations: Fix

[roberth]

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[roberth]

@ofborg test nixos-rebuild-specialisations

[roberth]

Fixed for linux, but why does it fail on arm? @RaitoBezarius is this also due to disk handling changes?

machine # Installing for arm64-efi platform.
machine # /nix/store/v25ypi8bj8ahg1l9vsba6mcyl12wp406-grub-2.06/sbin/grub-install: error: cannot find EFI directory.
machine # /nix/store/18w2h1dx2ljd324kzddwr49v5s09aiay-install-grub.pl: installation of GRUB on /dev/vda failed: No such file or directory
machine # warning: error(s) occurred while switching to the new configuration
machine: output: 
Test "Switch to the base system" failed with error: "command `nixos-rebuild switch` failed (exit code 1)"

(see ofborg, https://github.com/NixOS/nixpkgs/pull/237069/checks?check_run_id=14158223935)

[RaitoBezarius]

Wouldn't this make the closure explode? :-(

I mean I dream of using this everywhere (while waiting for rebuildDependencyClosure which @JulienMalka is exploring).

[roberth]

Not the build closure ;)

It balloons, but does not explode.
Right now the test itself explodes. Pieces everywhere.

[roberth]

@JulienMalka

Awesome!

Added some thoughts here #180529 (comment)

[roberth]

So realistically I think our priorities should be

1. maintainable tests
2. working tests
3. fast tests

This PR doesn't make (3) harder, because it's easy enough to find tests that do includeBuildDependencies = true.
Meanwhile it fixes (1) and (2).

[RaitoBezarius]

I'm on board with the "correct by design".

[RaitoBezarius]

Fixed for linux, but why does it fail on arm? @RaitoBezarius is this also due to disk handling changes?

machine # Installing for arm64-efi platform.
machine # /nix/store/v25ypi8bj8ahg1l9vsba6mcyl12wp406-grub-2.06/sbin/grub-install: error: cannot find EFI directory.
machine # /nix/store/18w2h1dx2ljd324kzddwr49v5s09aiay-install-grub.pl: installation of GRUB on /dev/vda failed: No such file or directory
machine # warning: error(s) occurred while switching to the new configuration
machine: output: 
Test "Switch to the base system" failed with error: "command `nixos-rebuild switch` failed (exit code 1)"

(see ofborg, https://github.com/NixOS/nixpkgs/pull/237069/checks?check_run_id=14158223935)

Looks like a bug/problem in GRUB installer script again, I think. But of course, my disk changes could have make this bug "visible" again.

I assume the target for GRUB device should be nodev to make this work on UEFI, otherwise, it needs legacy boot.

[roberth]

Looks like a bug/problem in GRUB installer script again

Can't really dive into that now.