Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustPlatform.bindgenHook: use the correct Libsystem on the 11.0 SDK #233815

Merged
merged 2 commits into from
May 24, 2023

Conversation

reckenrode
Copy link
Contributor

Description of changes

While troubleshooting ipetkov/crane#329, I found that the 11.0 SDK rustPlatform.bindgenHook was propagating Libsystem from the 10.12 SDK (because the hook exports Clang’s nix-support/libc-c(xx)flags). Providing it with a wrapped Clang using the 11.0 SDK Libsystem resolves the issue.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@wegank
Copy link
Member

wegank commented May 24, 2023

Nice! I'll check if killport can migrate to rustPlatform.bindgenHook.

EDIT: It works!

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 24, 2023
@wegank
Copy link
Member

wegank commented May 24, 2023

Trying to eliminate aarch64-darwin rebuilds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants