Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darwin.libtapi: Build with libcxxStdenv on non-Darwin #233535

Closed
wants to merge 1 commit into from

Conversation

zhaofengli
Copy link
Member

Description of changes

This PR fixes linking in cctools-port which is built with libcxxStdenv. There is no rebuild on Darwin and fixes darwin.cctools on non-Darwin.

Without this, C++ ABI says hi (and we don't want them to say hi 😛):

/nix/store/22p5nv7fbxhm06mfkwwnibv1nsz06x4b-binutils-2.40/bin/ld: textstub_dylib_file.cpp:(.text._ZN8textstub5dylib4FileI8arm64_32E4initEPN4tapi2v119LinkerInterfaceFileEPK7OptionsbbbbPKcRKN2ld10VersionSetESC_bbbb[_ZN8textstub5dylib4FileI8arm64_32E4initEPN4tapi2v119LinkerInterfaceFileEPK7OptionsbbbbPKcRKN2ld10VersionSetESC_bbbb]+0x88d): undefined reference to `tapi::v1::LinkerInterfaceFile::ignoreExports() const'
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This fixes linking in cctools-port which is built with libcxxStdenv.
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
@zhaofengli
Copy link
Member Author

No longer needed since #307880. Tested that libtapi builds on x86_64-linux.

@zhaofengli zhaofengli closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 12.approvals: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants