palemoon: Drop #232571
Merged
palemoon: Drop #232571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has Python 2.x as a build-time dependency, which has been EOL for years and was finally marked as insecure in NixOS#201859. As such, it has been unbuildable on master without enabling insecure packages for almost half a year. Upstream has no plans to migrate their build system away from py2 (though they might accept help with it), so we'll have to drop it: https://forum.palemoon.org/viewtopic.php?f=62&t=28863&p=232152
ofborg
bot
added
8.has: clean-up
10.rebuild-darwin: 0
wegank
approved these changes
May 18, 2023
wegank
added
the
12.approvals: 1
Scrumplex
approved these changes
May 18, 2023
Scrumplex
added
12.approvals: 2
|
Tagging @AndersonTorres as the other maintainer |
|
Goodbye, palemoon! See you someday! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
It has Python 2.x as a build-time dependency, which has been EOL for years and was finally marked as insecure in #201859. As such, it has been unbuildable on master without enabling insecure packages for almost half a year.
Upstream has no plans to migrate their build system away from py2 (though they might accept help with it), so we'll have to drop it: https://forum.palemoon.org/viewtopic.php?f=62&t=28863&p=232152
I've tried replacing
python2withpypy, but that doesn't seem to work:Forum reports indicate that building with tauthon would work but I don't know what the attitude towards introducing that is, or if/how they address any CVEs that py2 has accumulated / will accumulate.
CC @AndersonTorres
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)