-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meshcentral: 1.1.6 -> 1.1.19 #227042
meshcentral: 1.1.6 -> 1.1.19 #227042
Conversation
c58da45
to
4e3d794
Compare
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript. meta.description for meshcentral is: Computer management web app meta.homepage for meshcentral is: https://meshcentral.com/info/ Updates performed
To inspect upstream changesImpactChecks done (click to expand)
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.) Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build resultsWe have automatically built all packages that will get rebuilt due to This gives evidence on whether the upgrade will break dependent packages. Result of 1 package built:
Maintainer pingscc @lheckemann for testing. |
4e3d794
to
186a8d4
Compare
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript. meta.description for meshcentral is: Computer management web app meta.homepage for meshcentral is: https://meshcentral.com/info/ Updates performed
To inspect upstream changesImpactChecks done (click to expand)
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.) Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build resultsWe have automatically built all packages that will get rebuilt due to This gives evidence on whether the upgrade will break dependent packages. Result of 1 package built:
Maintainer pingscc @lheckemann for testing. |
4e3d794
to
186a8d4
Compare
186a8d4
to
f253143
Compare
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript. meta.description for meshcentral is: Computer management web app meta.homepage for meshcentral is: https://meshcentral.com/info/ Updates performed
To inspect upstream changesImpactChecks done (click to expand)
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.) Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build resultsWe have automatically built all packages that will get rebuilt due to This gives evidence on whether the upgrade will break dependent packages. Result of 1 package built:
Maintainer pingscc @lheckemann for testing. |
f253143
to
d121dca
Compare
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript. meta.description for meshcentral is: Computer management web app meta.homepage for meshcentral is: https://meshcentral.com/info/ Updates performed
To inspect upstream changesImpactChecks done (click to expand)
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.) Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build resultsWe have automatically built all packages that will get rebuilt due to This gives evidence on whether the upgrade will break dependent packages. Result of 1 package built:
Maintainer pingscc @lheckemann for testing. |
d121dca
to
3878025
Compare
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript. meta.description for meshcentral is: Computer management web app meta.homepage for meshcentral is: https://meshcentral.com/ Updates performed
To inspect upstream changesImpactChecks done (click to expand)
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.) Or, build yourself:
Or:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build resultsWe have automatically built all packages that will get rebuilt due to This gives evidence on whether the upgrade will break dependent packages. Result of 1 package built:
Maintainer pingscc @lheckemann for testing. |
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript. meta.description for meshcentral is: Computer management web app meta.homepage for meshcentral is: https://meshcentral.com/ Updates performed
To inspect upstream changesImpactChecks done (click to expand)
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.) Or, build yourself:
Or:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build resultsWe have automatically built all packages that will get rebuilt due to This gives evidence on whether the upgrade will break dependent packages. Result of 1 package built:
Maintainer pingscc @lheckemann for testing. |
3878025
to
b65117d
Compare
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript. meta.description for meshcentral is: Computer management web app meta.homepage for meshcentral is: https://meshcentral.com/ Updates performed
To inspect upstream changesImpactChecks done (click to expand)
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.) Or, build yourself:
Or:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build resultsWe have automatically built all packages that will get rebuilt due to This gives evidence on whether the upgrade will break dependent packages. Result of 1 package built:
Maintainer pingscc @lheckemann for testing. |
b65117d
to
bf75488
Compare
According to Ylianst/MeshCentral#5619 (comment),
I suggest we drop the package because it is incompatible with Nix. |
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript. meta.description for meshcentral is: Computer management web app meta.homepage for meshcentral is: https://meshcentral.com/ Updates performed
To inspect upstream changesImpactChecks done
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.) Or, build yourself:
Or:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build resultsWe have automatically built all packages that will get rebuilt due to This gives evidence on whether the upgrade will break dependent packages. Result of 1 package built:
Maintainer pingscc @lheckemann for testing. |
bf75488
to
cc1c593
Compare
@lheckemann Can you please review? Otherwise I'll just merge in a few days because it builds. |
@dotlambda You've made it quite clear that you're not engaging properly with this package. Please just leave it alone if you're not going to check if the change makes sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs an actual review with testing, not just "it builds"
Yes, and despite this PR being open for nine months you still haven't done so. That's why I asked for your review. If we're not gonna update this package anymore we might as well remove it for being unmaintained. |
Fine, I'll try to squash it into my todos. But I gotta say, this isn't the first time you're applying needless pressure because you interpret something to be unmaintained and that's upsetting. I can't remember having signed an SLA. From what I read you don't even use it, so why do you care so much about this specific package? There are 6067 other outdated packages according to Repology and I'm sure there's quite a bunch of other packages that are outdated for a little longer and by your questionable definition unmaintained. There's no indication of a security-relevant fix in the past releases and I know of folks successfully using this package, so while I do acknowledge that it's unfortunate that this doesn't get updated right now, it's just not a high priority. |
Fair.
I only cared because I was trying to remove vendored lock files. But I guess I now know it won't be possible to remove more than just |
Current state works fine for me. |
It is used because there is no |
Dang, you're right. Should've checked with |
Thanks for taking over @Ma27 ❤️ |
Discussed this with Linus in private.
2ddd9bf
to
dc8293a
Compare
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for meshcentral is: Computer management web app
meta.homepage for meshcentral is: https://meshcentral.com/info/
Updates performed
To inspect upstream changes
Impact
Checks done (click to expand)
passthru.tests
, if any, passedRebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-users
list or you can usesudo
since root is effectively trusted.Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of
nixpkgs-review
run on x86_64-linux 11 package built:
Maintainer pings
cc @lheckemann for testing.