Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meshcentral: 1.1.6 -> 1.1.19 #227042

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for meshcentral is: Computer management web app

meta.homepage for meshcentral is: https://meshcentral.com/info/

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.1.5 with grep in /nix/store/rqxmlzd1kyya7l2scq5k1c7nzwlcjsdx-meshcentral-1.1.5
  • found 1.1.5 in filename of file in /nix/store/rqxmlzd1kyya7l2scq5k1c7nzwlcjsdx-meshcentral-1.1.5

Rebuild report (if merged into master) (click to expand)
1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
meshcentral
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/rqxmlzd1kyya7l2scq5k1c7nzwlcjsdx-meshcentral-1.1.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A meshcentral https://github.com/r-ryantm/nixpkgs/archive/c58da453622c7e8fd43e29d493868c4840993f1b.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/rqxmlzd1kyya7l2scq5k1c7nzwlcjsdx-meshcentral-1.1.5
ls -la /nix/store/rqxmlzd1kyya7l2scq5k1c7nzwlcjsdx-meshcentral-1.1.5/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • meshcentral

Maintainer pings

cc @lheckemann for testing.

@wegank wegank marked this pull request as draft April 19, 2023 10:41
@r-ryantm r-ryantm changed the title meshcentral: 1.1.5 -> 1.1.5 meshcentral: 1.1.6 -> 1.1.6 Jun 23, 2023
@r-ryantm
Copy link
Contributor Author

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for meshcentral is: Computer management web app

meta.homepage for meshcentral is: https://meshcentral.com/info/

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.1.6 with grep in /nix/store/qy76frsy2hyy2nx4vns7fniwi24fg2yc-meshcentral-1.1.6
  • found 1.1.6 in filename of file in /nix/store/qy76frsy2hyy2nx4vns7fniwi24fg2yc-meshcentral-1.1.6

Rebuild report (if merged into master) (click to expand)
1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
meshcentral
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/qy76frsy2hyy2nx4vns7fniwi24fg2yc-meshcentral-1.1.6 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A meshcentral https://github.com/r-ryantm/nixpkgs/archive/4e3d794dd6a354ae19cf70b66d2614a071415dd6.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/qy76frsy2hyy2nx4vns7fniwi24fg2yc-meshcentral-1.1.6
ls -la /nix/store/qy76frsy2hyy2nx4vns7fniwi24fg2yc-meshcentral-1.1.6/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • meshcentral

Maintainer pings

cc @lheckemann for testing.

@r-ryantm r-ryantm changed the title meshcentral: 1.1.6 -> 1.1.6 meshcentral: 1.1.6 -> 1.1.8 Aug 10, 2023
@r-ryantm
Copy link
Contributor Author

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for meshcentral is: Computer management web app

meta.homepage for meshcentral is: https://meshcentral.com/info/

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.1.8 with grep in /nix/store/nf0q80qd93dlajhc4h987wlw9445lf48-meshcentral-1.1.8
  • found 1.1.8 in filename of file in /nix/store/nf0q80qd93dlajhc4h987wlw9445lf48-meshcentral-1.1.8

Rebuild report (if merged into master) (click to expand)
1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
meshcentral
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/nf0q80qd93dlajhc4h987wlw9445lf48-meshcentral-1.1.8 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A meshcentral https://github.com/r-ryantm/nixpkgs/archive/186a8d4175c1045b4eddbb430a01911a58c4b00c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/nf0q80qd93dlajhc4h987wlw9445lf48-meshcentral-1.1.8
ls -la /nix/store/nf0q80qd93dlajhc4h987wlw9445lf48-meshcentral-1.1.8/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • meshcentral

Maintainer pings

cc @lheckemann for testing.

@ofborg ofborg bot requested a review from lheckemann August 10, 2023 11:33
@r-ryantm r-ryantm changed the title meshcentral: 1.1.6 -> 1.1.8 meshcentral: 1.1.6 -> 1.1.10 Aug 20, 2023
@r-ryantm
Copy link
Contributor Author

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for meshcentral is: Computer management web app

meta.homepage for meshcentral is: https://meshcentral.com/info/

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.1.10 with grep in /nix/store/wkray8h7wdqj2rh0nk0nai2rjdb5c5g0-meshcentral-1.1.10
  • found 1.1.10 in filename of file in /nix/store/wkray8h7wdqj2rh0nk0nai2rjdb5c5g0-meshcentral-1.1.10

Rebuild report (if merged into master) (click to expand)
1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
meshcentral
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/wkray8h7wdqj2rh0nk0nai2rjdb5c5g0-meshcentral-1.1.10 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A meshcentral https://github.com/r-ryantm/nixpkgs/archive/f2531438597274fa01b44f865be80c061cb81cc5.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/wkray8h7wdqj2rh0nk0nai2rjdb5c5g0-meshcentral-1.1.10
ls -la /nix/store/wkray8h7wdqj2rh0nk0nai2rjdb5c5g0-meshcentral-1.1.10/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • meshcentral

Maintainer pings

cc @lheckemann for testing.

@r-ryantm r-ryantm changed the title meshcentral: 1.1.6 -> 1.1.10 meshcentral: 1.1.6 -> 1.1.11 Sep 13, 2023
@r-ryantm
Copy link
Contributor Author

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for meshcentral is: Computer management web app

meta.homepage for meshcentral is: https://meshcentral.com/info/

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.1.11 with grep in /nix/store/1z3jq2ppgf7c7rf3dgr0d2as197hvz7a-meshcentral-1.1.11
  • found 1.1.11 in filename of file in /nix/store/1z3jq2ppgf7c7rf3dgr0d2as197hvz7a-meshcentral-1.1.11

Rebuild report (if merged into master) (click to expand)
1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
meshcentral
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/1z3jq2ppgf7c7rf3dgr0d2as197hvz7a-meshcentral-1.1.11 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A meshcentral https://github.com/r-ryantm/nixpkgs/archive/d121dcad9497d6dba69af6ed533470ebdec91560.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/1z3jq2ppgf7c7rf3dgr0d2as197hvz7a-meshcentral-1.1.11
ls -la /nix/store/1z3jq2ppgf7c7rf3dgr0d2as197hvz7a-meshcentral-1.1.11/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • meshcentral

Maintainer pings

cc @lheckemann for testing.

@r-ryantm r-ryantm changed the title meshcentral: 1.1.6 -> 1.1.11 meshcentral: 1.1.6 -> 1.1.13 Oct 11, 2023
@r-ryantm
Copy link
Contributor Author

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for meshcentral is: Computer management web app

meta.homepage for meshcentral is: https://meshcentral.com/

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.1.13 with grep in /nix/store/81cv18qnl2hml4nd4fsv0rv4vq3z79c7-meshcentral-1.1.13
  • found 1.1.13 in filename of file in /nix/store/81cv18qnl2hml4nd4fsv0rv4vq3z79c7-meshcentral-1.1.13

Rebuild report (if merged into master) (click to expand)
1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
meshcentral
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/81cv18qnl2hml4nd4fsv0rv4vq3z79c7-meshcentral-1.1.13 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A meshcentral https://github.com/r-ryantm/nixpkgs/archive/38780256b9a9b82fdfbd87104d8e429c5c205dd6.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/38780256b9a9b82fdfbd87104d8e429c5c205dd6#meshcentral

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/81cv18qnl2hml4nd4fsv0rv4vq3z79c7-meshcentral-1.1.13
ls -la /nix/store/81cv18qnl2hml4nd4fsv0rv4vq3z79c7-meshcentral-1.1.13/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • meshcentral

Maintainer pings

cc @lheckemann for testing.

@r-ryantm r-ryantm changed the title meshcentral: 1.1.6 -> 1.1.13 meshcentral: 1.1.6 -> 1.1.14 Oct 31, 2023
@r-ryantm
Copy link
Contributor Author

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for meshcentral is: Computer management web app

meta.homepage for meshcentral is: https://meshcentral.com/

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.1.14 with grep in /nix/store/jfhzqm4vfkw1vvqryii230pdpvdskz98-meshcentral-1.1.14
  • found 1.1.14 in filename of file in /nix/store/jfhzqm4vfkw1vvqryii230pdpvdskz98-meshcentral-1.1.14

Rebuild report (if merged into master) (click to expand)
1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
meshcentral
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/jfhzqm4vfkw1vvqryii230pdpvdskz98-meshcentral-1.1.14 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A meshcentral https://github.com/r-ryantm/nixpkgs/archive/b65117d9222057e7ea931285c820a62bbf48f04b.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/b65117d9222057e7ea931285c820a62bbf48f04b#meshcentral

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/jfhzqm4vfkw1vvqryii230pdpvdskz98-meshcentral-1.1.14
ls -la /nix/store/jfhzqm4vfkw1vvqryii230pdpvdskz98-meshcentral-1.1.14/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • meshcentral

Maintainer pings

cc @lheckemann for testing.

@r-ryantm r-ryantm changed the title meshcentral: 1.1.6 -> 1.1.14 meshcentral: 1.1.6 -> 1.1.16 Dec 16, 2023
@r-ryantm
Copy link
Contributor Author

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for meshcentral is: Computer management web app

meta.homepage for meshcentral is: https://meshcentral.com/

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.1.16 with grep in /nix/store/cmfslk4mf5cf07n3jnrl0szl65cb571f-meshcentral-1.1.16
  • found 1.1.16 in filename of file in /nix/store/cmfslk4mf5cf07n3jnrl0szl65cb571f-meshcentral-1.1.16

Rebuild report (if merged into master) (click to expand)
1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
meshcentral
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/cmfslk4mf5cf07n3jnrl0szl65cb571f-meshcentral-1.1.16 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A meshcentral https://github.com/r-ryantm/nixpkgs/archive/bf7548813bbe5770df4324b805739d2fdce98439.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/bf7548813bbe5770df4324b805739d2fdce98439#meshcentral

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/cmfslk4mf5cf07n3jnrl0szl65cb571f-meshcentral-1.1.16
ls -la /nix/store/cmfslk4mf5cf07n3jnrl0szl65cb571f-meshcentral-1.1.16/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • meshcentral

Maintainer pings

cc @lheckemann for testing.

@wegank wegank marked this pull request as ready for review January 5, 2024 17:40
@wegank wegank requested a review from dotlambda January 5, 2024 17:43
@dotlambda
Copy link
Member

According to Ylianst/MeshCentral#5619 (comment),

meshcentral installs packages on the fly if they are missing.

I suggest we drop the package because it is incompatible with Nix.

@dotlambda dotlambda requested a review from Ma27 January 8, 2024 21:27
@lheckemann
Copy link
Member

lheckemann commented Jan 10, 2024

@r-ryantm r-ryantm changed the title meshcentral: 1.1.6 -> 1.1.16 meshcentral: 1.1.6 -> 1.1.19 Jan 20, 2024
@r-ryantm
Copy link
Contributor Author

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for meshcentral is: Computer management web app

meta.homepage for meshcentral is: https://meshcentral.com/

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.1.19 with grep in /nix/store/2kbgryr5w7h0pnr23fish2bfxrva7iqg-meshcentral-1.1.19
  • found 1.1.19 in filename of file in /nix/store/2kbgryr5w7h0pnr23fish2bfxrva7iqg-meshcentral-1.1.19

Rebuild report (if merged into master) (click to expand)
1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
meshcentral
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/2kbgryr5w7h0pnr23fish2bfxrva7iqg-meshcentral-1.1.19 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A meshcentral https://github.com/r-ryantm/nixpkgs/archive/cc1c593b1a8a83348459a77627f0cc53de0ec68c.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/cc1c593b1a8a83348459a77627f0cc53de0ec68c#meshcentral

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/2kbgryr5w7h0pnr23fish2bfxrva7iqg-meshcentral-1.1.19
ls -la /nix/store/2kbgryr5w7h0pnr23fish2bfxrva7iqg-meshcentral-1.1.19/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • meshcentral

Maintainer pings

cc @lheckemann for testing.

@dotlambda
Copy link
Member

dotlambda commented Jan 20, 2024

@lheckemann Can you please review? Otherwise I'll just merge in a few days because it builds.

@lheckemann
Copy link
Member

@dotlambda You've made it quite clear that you're not engaging properly with this package. Please just leave it alone if you're not going to check if the change makes sense.

Copy link
Member

@lheckemann lheckemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an actual review with testing, not just "it builds"

@dotlambda
Copy link
Member

Needs an actual review with testing, not just "it builds"

Yes, and despite this PR being open for nine months you still haven't done so. That's why I asked for your review. If we're not gonna update this package anymore we might as well remove it for being unmaintained.

@Ma27
Copy link
Member

Ma27 commented Jan 22, 2024

Fine, I'll try to squash it into my todos.

But I gotta say, this isn't the first time you're applying needless pressure because you interpret something to be unmaintained and that's upsetting. I can't remember having signed an SLA.

From what I read you don't even use it, so why do you care so much about this specific package? There are 6067 other outdated packages according to Repology and I'm sure there's quite a bunch of other packages that are outdated for a little longer and by your questionable definition unmaintained. There's no indication of a security-relevant fix in the past releases and I know of folks successfully using this package, so while I do acknowledge that it's unfortunate that this doesn't get updated right now, it's just not a high priority.

@dotlambda
Copy link
Member

But I gotta say, this isn't the first time you're applying needless pressure because you interpret something to be unmaintained and that's upsetting. I can't remember having signed an SLA.

Fair.

From what I read you don't even use it, so why do you care so much about this specific package?

I only cared because I was trying to remove vendored lock files. But I guess I now know it won't be possible to remove more than just yarn.nix and should stop caring.

@Ma27
Copy link
Member

Ma27 commented Jan 24, 2024

Current state works fine for me.
Removed offlineCache for now: while I do acknowledge that we should probably switch, that one isn't used and it doesn't make any sense to build it.

@dotlambda
Copy link
Member

Removed offlineCache for now: while I do acknowledge that we should probably switch, that one isn't used and it doesn't make any sense to build it.

It is used because there is no yarn.nix.

@Ma27
Copy link
Member

Ma27 commented Jan 24, 2024

Dang, you're right. Should've checked with --option allow-import-from-derivation false.

@lheckemann
Copy link
Member

Thanks for taking over @Ma27 ❤️

Discussed this with Linus in private.
@Ma27 Ma27 merged commit f9ce328 into NixOS:master Jan 24, 2024
22 of 23 checks passed
@r-ryantm r-ryantm deleted the auto-update/meshcentral branch January 24, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants