Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rav1e: fix cross #225358

Closed
wants to merge 677 commits into from
Closed

rav1e: fix cross #225358

wants to merge 677 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 9, 2023

Description of changes

cargo cbuild needs to have the C{C,XX}_FOR_{${platform}} variables set just like cargo since it is basically a wrapper around cargo. Without these variables, it will try to use the hostPlatform C compiler to compile build.rs scripts, and will pass flags to that compiler which only make sense on the buildPlatform. So it's just doomed without the environment variables.

Right now it looks like rav1e is the only package we have that is using cargo-c, but if that changes in the future we should factor this out as its own hook, like maturinBuildHook and the others.

Closes #225356

Things done
  • Built on platform(s)
    • aarch64-linux (cross from x86_64-linux)
  • Fits CONTRIBUTING.md.

jtojnar and others added 30 commits April 6, 2023 01:35
@jtojnar
gnome-builder: 43.6 → 44.beta
a67dd08 
https://gitlab.gnome.org/GNOME/gnome-builder/-/compare/43.6...44.beta

Co-authored-by: Bobby Rong <[email protected]>

Changelog-Reviewed-By: Jan Tojnar <[email protected]>
@jtojnar
gnome-text-editor: 43.2 → 44.beta
a22bd5f 
https://gitlab.gnome.org/GNOME/gnome-text-editor/-/compare/43.2...44.beta

Changelog-Reviewed-By: Jan Tojnar <[email protected]>
@bobby285271 @jtojnar
gtk-frdp: unstable-2022-04-11 → unstable-2023-02-11
32bf3e9 
https://gitlab.gnome.org/GNOME/gtk-frdp/-/compare/d7f408fb23adc01db14c708b35b74a317418de4b...f506b8a3e55a1bb4cab39c68c7c0c34629c78633

API version is bumped to 0.2, this is now needed by gnome-connections.

Changelog-Reviewed-By: Jan Tojnar <[email protected]>
@bobby285271 @jtojnar
evolution-data-server: 3.46.4 → 3.47.2
971dd3a 
https://gitlab.gnome.org/GNOME/evolution-data-server/-/compare/3.46.4...3.47.2

Changelog-Reviewed-By: Jan Tojnar <[email protected]>
@bobby285271 @jtojnar
webkitgtk: 2.38.5 → 2.39.90
ee55ba5 
https://webkitgtk.org/2022/11/11/webkitgtk2.39.1-released.html
https://webkitgtk.org/2022/11/28/webkitgtk2.39.2-released.html
https://webkitgtk.org/2022/12/14/webkitgtk2.39.3-released.html
https://webkitgtk.org/2023/01/16/webkitgtk2.39.4-released.html
https://webkitgtk.org/2023/01/19/webkitgtk2.39.5-released.html
https://webkitgtk.org/2023/01/30/webkitgtk2.39.6-released.html
https://webkitgtk.org/2023/01/31/webkitgtk2.39.7-released.html
https://webkitgtk.org/2023/02/20/webkitgtk2.39.90-released.html

Changelog-Reviewed-By: Jan Tojnar <[email protected]>
@bobby285271 @jtojnar
webkitgtk_6_0: init, webkitgtk_5_0: drop
0f4129c 
GTK 4 API version is bumped to 6.0.
i.e. we now only have webkitgtk-6.0, and no more webkit2gtk-5.0.
@bobby285271 @jtojnar
libdex: init at 0.1.0
f1e4f33 
https://gitlab.gnome.org/GNOME/gnome-builder/-/commit/17f35418d26d0b1a6077bd38fcbbd3961085cd43
https://gitlab.gnome.org/GNOME/libdex

Co-authored-by: Jan Tojnar <[email protected]>
@jtojnar
gnome-online-accounts: 3.46.0 → 3.47.1
4a8fff8 
https://gitlab.gnome.org/GNOME/gnome-online-accounts/-/compare/3.46.0...3.47.1

Changelog-Reviewed-By: Jan Tojnar <[email protected]>
@jtojnar
epiphany: 44.beta → 44.rc
3b9d20a 
https://gitlab.gnome.org/GNOME/epiphany/-/compare/44.beta...44.rc

Changelog-Reviewed-By: Jan Tojnar <[email protected]>
@jtojnar
evolution: 3.47.2 → 3.47.3
48d92a5 
https://gitlab.gnome.org/GNOME/evolution/-/compare/3.47.2...3.47.3

Changelog-Reviewed-By: Jan Tojnar <[email protected]>
@jtojnar
glib: 2.75.3 → 2.75.4
ceeb9f3 
https://gitlab.gnome.org/GNOME/glib/-/compare/2.75.3...2.75.4

Changelog-Reviewed-By: Jan Tojnar <[email protected]>
@jtojnar
gnome.gnome-calculator: 44.beta → 44.rc
7cd1411 
https://gitlab.gnome.org/GNOME/gnome-calculator/-/compare/44.beta...44.rc

Changelog-Reviewed-By: Jan Tojnar <[email protected]>
@jtojnar
gnome.gnome-initial-setup: 44.beta → 44.rc
805156c 
https://gitlab.gnome.org/GNOME/gnome-initial-setup/-/compare/44.beta...44.rc

Changelog-Reviewed-By: Jan Tojnar <[email protected]>
@jtojnar
gnome.gnome-disk-utility: 44.beta → 44.rc
50c1ec9 
https://gitlab.gnome.org/GNOME/gnome-disk-utility/-/compare/44.beta...44.rc

Changelog-Reviewed-By: Jan Tojnar <[email protected]>
@jtojnar
gnome.gnome-maps: 44.beta → 44.rc
efbb92a 
https://gitlab.gnome.org/GNOME/gnome-maps/-/compare/v44.beta...v44.rc

Changelog-Reviewed-By: Jan Tojnar <[email protected]>
@jtojnar
gnome.gnome-software: 44.beta → 44.rc
129f2ff 
https://gitlab.gnome.org/GNOME/gnome-software/-/compare/44.beta...44.rc

Changelog-Reviewed-By: Jan Tojnar <[email protected]>
@jtojnar
gnome.gnome-system-monitor: 44.beta → 44.rc
9aae7ce 
https://gitlab.gnome.org/GNOME/gnome-system-monitor/-/compare/44.beta...44.rc

Changelog-Reviewed-By: Jan Tojnar <[email protected]>
@jtojnar
gtk-frdp: unstable-2023-02-11 → unstable-2023-03-03
75221ea 
https://gitlab.gnome.org/GNOME/gtk-frdp/-/compare/f506b8a3e55a1bb4cab39c68c7c0c34629c78633...3f991a22c025cad3016a7aa55988e51884964050

Changelog-Reviewed-By: Jan Tojnar <[email protected]>
@jtojnar
gnome-connections: 44.beta → 44.rc
6d4256f 
https://gitlab.gnome.org/GNOME/connections/-/compare/44.beta...44.rc

Changelog-Reviewed-By: Jan Tojnar <[email protected]>
@jtojnar
gnome-builder: 44.beta → 44.rc
4f5e2fa 
https://gitlab.gnome.org/GNOME/gnome-builder/-/compare/44.beta...44.rc

Changelog-Reviewed-By: Jan Tojnar <[email protected]>
@jtojnar
gnome-text-editor: 44.beta → 44.rc
99edcdf 
https://gitlab.gnome.org/GNOME/gnome-text-editor/-/compare/44.beta...44.rc

Changelog-Reviewed-By: Jan Tojnar <[email protected]>
@jtojnar
gtksourceview5: 5.7.1 → 5.7.2
ce0edfa 
https://gitlab.gnome.org/GNOME/gtksourceview/-/compare/5.7.1...5.7.2

Changelog-Reviewed-By: Jan Tojnar <[email protected]>
@jtojnar
gtk3: 3.24.36 → 3.24.37
68683ec 
https://gitlab.gnome.org/GNOME/gtk/-/compare/3.24.36...3.24.37

- Removes legacy Wayland text input module.

Changelog-Reviewed-By: Jan Tojnar <[email protected]>
@jtojnar
jsonrpc-glib: 3.42.0 → 3.43.0
6267cbe 
https://gitlab.gnome.org/GNOME/jsonrpc-glib/-/compare/3.42.0...3.43.0

Changelog-Reviewed-By: Jan Tojnar <[email protected]>
@jtojnar
libpanel: 1.1.1 → 1.1.2
f19f5d0 
https://gitlab.gnome.org/GNOME/libpanel/-/compare/1.1.1...1.1.2

Changelog-Reviewed-By: Jan Tojnar <[email protected]>
@jtojnar
pango: 1.50.13 → 1.50.14
bb07a5b 
https://gitlab.gnome.org/GNOME/pango/-/compare/1.50.13...1.50.14

Changelog-Reviewed-By: Jan Tojnar <[email protected]>
@jtojnar
template-glib: 3.36.0 → 3.36.1
a00aece 
https://gitlab.gnome.org/GNOME/template-glib/-/compare/3.36.0...3.36.1

Changelog-Reviewed-By: Jan Tojnar <[email protected]>
@jtojnar
gnome.hitori: 3.38.4 → 44.0
83d3c54 
https://gitlab.gnome.org/GNOME/hitori/-/compare/3.38.4...44.0

Changelog-Reviewed-By: Jan Tojnar <[email protected]>
@jtojnar
evolution-data-server: 3.47.2 → 3.47.3
da6fc44 
https://gitlab.gnome.org/GNOME/evolution-data-server/-/compare/3.47.2...3.47.3

Changelog-Reviewed-By: Jan Tojnar <[email protected]>
@bobby285271 @jtojnar
gnome.gnome-terminal: Fix updateScript
1d846ea 
See https://gitlab.gnome.org/GNOME/gnome-terminal/-/blob/3.47.0/src/terminal-util.cc#L226-L230
@ghost ghost requested a review from Ericson2314 as a code owner April 9, 2023 00:53
@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Apr 9, 2023
@github-actions github-actions bot added 6.topic: emacs Text editor 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: lua 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: rust 6.topic: stdenv Standard environment 6.topic: systemd 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: vim 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 9, 2023
@ghost ghost closed this Apr 9, 2023
@ghost ghost locked as spam and limited conversation to collaborators Apr 9, 2023
@ghost ghost deleted the pr/fixcross/rav1e branch April 9, 2023 00:57
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

@kalbasit kalbasit Awaiting requested review from kalbasit

@Mic92 Mic92 Awaiting requested review from Mic92

@zowoq zowoq Awaiting requested review from zowoq

@adisbladis adisbladis Awaiting requested review from adisbladis

@ttuegel ttuegel Awaiting requested review from ttuegel

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@winterqt winterqt Awaiting requested review from winterqt

@figsoda figsoda Awaiting requested review from figsoda

@marsam marsam Awaiting requested review from marsam

@stigtsp stigtsp Awaiting requested review from stigtsp

@zakame zakame Awaiting requested review from zakame

@dasJ dasJ Awaiting requested review from dasJ

@FRidh FRidh Awaiting requested review from FRidh

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 6.topic: emacs Text editor 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: lua 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: rust 6.topic: stdenv Standard environment 6.topic: systemd 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: vim 8.has: changelog 8.has: clean-up 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv This PR causes stdenv to rebuild
Projects
Nix documentation
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pkgsCross.*.rav1e is broken