-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linuxPackages.nvidia_x11_production: 525.89.02 -> 525.105.17 #223939
Conversation
Result of 5 packages failed to build:
110 packages built:
|
This probably requires changes to the udev rules in the
This also breaks the heuristic we use to disable ibt (drivers >= 530), might need to add a passthru override property. |
I mostly copied the udev rules from fedora with minor adjustments iirc, you may want to have a look at their package for this version, if they have bumped it already that is |
What about lowering the bar to |
While that would work this time, the 470 branch is still officially supported and when that receives a IBT-compatible release we will need to implement an override anyway. |
eaf1b86
to
49c37f7
Compare
Changed the nvidia module to allow per-release overriding of IBT support, in case pre-530 builds add IBT support or nvidia releases a newer driver that somehow breaks IBT support. Regarding the udev changes the only distro that has packaged this release so far has been gentoo which doesn't bother with udev rules for obvious reasons. It should honestly be handle this in a future PR since it is caused by a change in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM, running nixpkgs-review.
If you don't want to rebuild linux kernels, I've actually been rebasing these PRs on |
Result of 1 package blacklisted:
5 packages failed to build:
95 packages built:
|
Having issues building:
Changing |
it should be |
Thanks for the quick fix and for this IBT toggling support development. :3 |
Description of changes
Based on NVIDIA/open-gpu-kernel-modules@525.89.02...525.105.17:
6.3
kernelThings done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)