Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages_git: apply #205355 (disable libpfm on non-Linux) #222902

Merged
merged 1 commit into from
Apr 19, 2023
Merged

llvmPackages_git: apply #205355 (disable libpfm on non-Linux) #222902

merged 1 commit into from
Apr 19, 2023

Conversation

rrbutani
Copy link
Contributor

This was applied to llvmPackages_15 in 81ef82a (though I appear to have forgotten to mention it in the commit message...)

cc: @alyssais

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 24, 2023
@rrbutani rrbutani mentioned this pull request Mar 26, 2023
Closed
48 tasks
@RaitoBezarius RaitoBezarius mentioned this pull request Apr 3, 2023
Closed
49 tasks
@rrbutani
llvmPackages_git: apply NixOS#205355 (disable libpfm on non-Linux)
75fed51 
this was applied to `llvmPackages_15` in 81ef82a
(though I appear to have forgotten to mention it in the commit message...)
@rrbutani rrbutani force-pushed the fix/llvm-git-disable-libpfm branch from 0c0595e to 75fed51 Compare April 3, 2023 15:33
@rrbutani rrbutani changed the base branch from staging to master April 3, 2023 15:33
@rrbutani rrbutani marked this pull request as ready for review April 3, 2023 15:50
@rrbutani rrbutani requested a review from matthewbauer as a code owner April 3, 2023 15:50
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Apr 3, 2023
@RaitoBezarius
Copy link
Member

@ofborg build llvmPackages_git.llvm

@RaitoBezarius RaitoBezarius merged commit 01a6895 into NixOS:master Apr 19, 2023
@RaitoBezarius
Copy link
Member

Result of nixpkgs-review pr 222902 run on x86_64-linux 1

@rrbutani rrbutani deleted the fix/llvm-git-disable-libpfm branch June 8, 2023 00:48
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaitoBezarius RaitoBezarius RaitoBezarius approved these changes

@alyssais alyssais Awaiting requested review from alyssais

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rrbutani @RaitoBezarius