Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages_git: apply #190936 (fix pkgsStatic LLVM build) #222901

Merged
merged 1 commit into from
Apr 5, 2023
Merged

llvmPackages_git: apply #190936 (fix pkgsStatic LLVM build) #222901

merged 1 commit into from
Apr 5, 2023

Conversation

rrbutani
Copy link
Contributor

This was applied to llvmPackages_15 in 81ef82a.

(waiting on my local build to finish to test but I assume we want this change for llvmPackages_git given that _15 has it)

cc: @alyssais

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 24, 2023
@rrbutani rrbutani mentioned this pull request Mar 26, 2023
Closed
48 tasks
@RaitoBezarius RaitoBezarius mentioned this pull request Apr 3, 2023
Closed
49 tasks
@rrbutani rrbutani force-pushed the fix/llvm-git-static-build-fix branch from 622ce51 to e505ffd Compare April 3, 2023 15:31
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: changelog 8.has: documentation This PR adds or changes documentation labels Apr 3, 2023
@rrbutani rrbutani changed the base branch from staging to master April 3, 2023 15:31
@github-actions github-actions bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog 6.topic: python labels Apr 3, 2023
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 3, 2023
@rrbutani rrbutani marked this pull request as ready for review April 3, 2023 15:50
@rrbutani rrbutani requested a review from matthewbauer as a code owner April 3, 2023 15:50
@RaitoBezarius
Copy link
Member

@ofborg build pkgsStatic.llvmPackages_git.llvm

@RaitoBezarius RaitoBezarius merged commit 5233468 into NixOS:master Apr 5, 2023
@rrbutani rrbutani deleted the fix/llvm-git-static-build-fix branch April 5, 2023 15:40
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaitoBezarius RaitoBezarius RaitoBezarius approved these changes

@alyssais alyssais Awaiting requested review from alyssais

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rrbutani @RaitoBezarius