Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to-html: init at 0.1.4 #221364

Merged
merged 1 commit into from
Jul 30, 2023
Merged

to-html: init at 0.1.4 #221364

merged 1 commit into from
Jul 30, 2023

Conversation

icewind1991
Copy link
Contributor

Description of changes

Add to-html 0.1.3, a "Terminal wrapper for rendering a terminal on a website by converting ANSI escape sequences to HTML".

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@GabrielDougherty
Copy link
Member

Result of nixpkgs-review pr 221364 run on x86_64-linux 1

1 package built:
  • to-html

@mweinelt mweinelt added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 6, 2023
@icewind1991 icewind1991 changed the title to-html: init at 0.1.3 to-html: init at 0.1.4 Jul 15, 2023
@icewind1991
Copy link
Contributor Author

updated to 0.1.4

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi !

Thanks for your contribution. I've left some comments.

pkgs/tools/text/to-html/default.nix Outdated Show resolved Hide resolved
pkgs/tools/text/to-html/default.nix Outdated Show resolved Hide resolved
pkgs/tools/text/to-html/default.nix Outdated Show resolved Hide resolved
@drupol drupol marked this pull request as draft July 26, 2023 16:23
@icewind1991 icewind1991 marked this pull request as ready for review July 27, 2023 20:23
@icewind1991 icewind1991 requested a review from drupol July 27, 2023 20:23
@drupol
Copy link
Contributor

drupol commented Jul 27, 2023

@icewind1991 I've use nix-init (nix run nixpkgs#nix-init -- -u https://github.com/Aloso/to-html) to generate the nix file for this program, here it is:

{ lib
, rustPlatform
, fetchFromGitHub
}:

rustPlatform.buildRustPackage rec {
  pname = "to-html";
  version = "0.1.4";

  src = fetchFromGitHub {
    owner = "Aloso";
    repo = "to-html";
    rev = "v${version}";
    hash = "sha256-zkTBjsMFhRz7lVRh8i+XkaJ/qWmTAMPnkH5aDhbHf8U=";
  };

  cargoHash = "sha256-hXc+lB3DKnRZkp1U5wW/vPKSZ0c1UknQCAxDfE7Eubg=";

  meta = with lib; {
    description = "Utilities for making the colo documentation";
    homepage = "https://github.com/Aloso/to-html";
    changelog = "https://github.com/Aloso/to-html/blob/${src.rev}/CHANGELOG.md";
    license = licenses.mit;
    maintainers = with maintainers; [ ];
  };
}

Can you compare and see if you're not missing anything? I quickly notice that you could add the meta.changelog attribute.

@drupol drupol marked this pull request as draft July 29, 2023 06:32
@icewind1991
Copy link
Contributor Author

added changelog

@icewind1991 icewind1991 marked this pull request as ready for review July 30, 2023 13:21
@drupol drupol merged commit 5fab052 into NixOS:master Jul 30, 2023
@icewind1991 icewind1991 deleted the to-html-0.1.3 branch August 2, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants