Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages_15.compiler-rt: drop codesign patch #218800

Merged
merged 1 commit into from
Mar 2, 2023
Merged

llvmPackages_15.compiler-rt: drop codesign patch #218800

merged 1 commit into from
Mar 2, 2023

Conversation

alyssais
Copy link
Member

Description of changes

This was added in 00839fe ("llvmPackages_15.compiler-rt: fixes for Darwin"), which says:

this introduces a codesigning related patch that we can drop once #195107 goes through

The referenced PR ("sigtool: 0.1.2 → 0.1.3") has now been merged, so I'm dropping the patch as instructed.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@alyssais
llvmPackages_15.compiler-rt: drop codesign patch
89be2b2 
This was added in 00839fe ("llvmPackages_15.compiler-rt: fixes for Darwin"),
which says:

> this introduces a codesigning related patch that we can drop once
> NixOS#195107 goes through

The referenced PR ("sigtool: 0.1.2 → 0.1.3") has now been merged, so
I'm dropping the patch as instructed.
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Feb 28, 2023
@alyssais alyssais added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 28, 2023
@alyssais alyssais merged commit 9bfc587 into NixOS:master Mar 2, 2023
@alyssais alyssais deleted the llvmPackages_15.compiler-rt-codesign branch March 2, 2023 12:36
@rrbutani rrbutani mentioned this pull request Mar 26, 2023
Closed
48 tasks
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrbutani rrbutani rrbutani approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@primeos primeos Awaiting requested review from primeos

@dtzWill dtzWill Awaiting requested review from dtzWill

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alyssais @rrbutani