Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang: drop the C++ std version -DCMAKE_CXX_FLAG #218671

Merged
merged 1 commit into from
Mar 10, 2023
Merged

clang: drop the C++ std version -DCMAKE_CXX_FLAG #218671

merged 1 commit into from
Mar 10, 2023

Conversation

alyssais
Copy link
Member

Port of 404ef6b ("llvmPackages_15.clang: drop the C++ std version -DCMAKE_CXX_FLAG"). The commit mentioned as removing the need for the override first appeared in LLVM 10.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@alyssais
clang: drop the C++ std version -DCMAKE_CXX_FLAG
3d99f20 
Port of 404ef6b ("llvmPackages_15.clang: drop the C++ std version
`-DCMAKE_CXX_FLAG`").  The commit mentioned as removing the need for
the override[1] first appeared in LLVM 10.

[1]: llvm/llvm-project@2724d9e
@ofborg ofborg bot added the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild label Feb 27, 2023
@alyssais alyssais added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 28, 2023
@rrbutani rrbutani added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Mar 6, 2023
@alyssais alyssais merged commit c5f7581 into NixOS:staging Mar 10, 2023
@alyssais alyssais deleted the clang-CMAKE_CXX_FLAG branch March 10, 2023 09:36
@rrbutani rrbutani mentioned this pull request Mar 26, 2023
Closed
48 tasks
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrbutani rrbutani rrbutani approved these changes

@trofi trofi trofi approved these changes

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@lovek323 lovek323 Awaiting requested review from lovek323

@dtzWill dtzWill Awaiting requested review from dtzWill

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@primeos primeos Awaiting requested review from primeos

Assignees
No one assigned
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alyssais @trofi @rrbutani