-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lld: build with 2M stack size on musl #218657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message should read lld though, maybe indicate somehow that it is about all available versions.
Port of 6485a02 ("llvm 14 lld: build with 2M stack size to fix firefox lto").
9cb2509
to
be9bdda
Compare
I think we should get into the habit of being surprised when an LLVM change is not applied to all versions, not when it is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subjective (and something I should have raised on the original PR or in the LLVM 15 PR) so feel free to ignore:
I'd really appreciate a comment here explaining why this is necessary (perhaps with a link to this (and maybe this/this) and a short snippet saying that the pkgsMusl.firefox
needs this -- or even just a link to #191372).
IMO it's a little hard to infer why this is needed from the surrounding context and while all the details are definitely still available in PR comments/commit messages, with our "copy the previous llvmPackages
's files" flow it takes a bit of effort to map back to the original commit (though I guess having llvmPackages_git
and keeping it up to date remedies this, somewhat).
Suggested-by: Rahul Butani <[email protected]>
Description of changes
Port of 6485a02 ("llvm 14 lld: build with 2M stack size to fix firefox lto").
LLVM 7 doesn't build for Musl for unrelated reasons, as it segfaults during a test. I gave up trying to fix it when I realised it doesn't do that if I
enableDebugging
.Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)