Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.ounit2: fix tests with OCaml < 4.07 #214801

Merged
merged 1 commit into from
Feb 5, 2023
Merged

ocamlPackages.ounit2: fix tests with OCaml < 4.07 #214801

merged 1 commit into from
Feb 5, 2023

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Feb 5, 2023

Description of changes

Fixes a regression due to #162385 (with a bit of cleaning).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@superherointj
Copy link
Contributor

Result of nixpkgs-review pr 214801 run on x86_64-linux 1

59 packages built:
  • acgtk
  • beluga
  • cmdstan
  • coccinelle
  • comby
  • coqPackages.serapi
  • cvehound
  • diffoscope
  • dune-release
  • easycrypt
  • eff
  • flitter
  • flow
  • framac
  • fstar
  • google-drive-ocamlfuse
  • guestfs-tools
  • haxe (haxe_4_2)
  • haxePackages.format
  • haxePackages.heaps
  • haxePackages.hlopenal
  • haxePackages.hlsdl
  • hxcpp (haxePackages.hxcpp)
  • haxePackages.hxcs
  • haxePackages.hxjava
  • haxePackages.hxnodejs_4
  • haxe_4_0
  • haxe_4_1
  • jackline
  • jasmin-compiler
  • libbap
  • libguestfs
  • ligo
  • liquidsoap
  • obelisk
  • ocaml-top
  • ocamlformat (ocamlformat_0_24_1)
  • ocamlformat_0_19_0
  • ocamlformat_0_20_0
  • ocamlformat_0_20_1
  • ocamlformat_0_21_0
  • ocamlformat_0_22_4
  • ocamlformat_0_23_0
  • opam-installer
  • opam2json
  • patdiff
  • python310Packages.bap
  • python310Packages.guestfs
  • python311Packages.bap
  • python311Packages.guestfs
  • reason
  • satysfi
  • soupault
  • stanc
  • stog
  • vagrant
  • virt-top
  • wayland-proxy-virtwl
  • why3

@superherointj superherointj merged commit 1a29a7a into NixOS:master Feb 5, 2023
@vbgl vbgl deleted the ocaml-ounit2-needs-ncurses branch February 6, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superherointj superherointj superherointj approved these changes

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbgl @superherointj