Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell: workaround for bug with dynamic libraries on darwin #21351

Closed
wants to merge 1 commit into from

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Dec 22, 2016

Motivation for this change

Workaround for haskell/cabal#4183
It seems like --extra-lib-dirs from the previous steps is not detected properly,
to work around this we build using a DYLD_LIBRARY_PATH and fixup the build afterwards.

/cc @domenkozar

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7 LnL7 added 2.status: work-in-progress This PR isn't done 6.topic: darwin Running or building packages on Darwin 6.topic: haskell labels Dec 22, 2016
@mention-bot
Copy link

@LnL7, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peti, @cstrahan and @Ericson2314 to be potential reviewers.

@peti
Copy link
Member

peti commented Dec 22, 2016

Pushed to haskell-updates in c3a58ad2bfc44c9924f99c7d08da25bffbc50105. I'll merge to master once the test builds at http://hydra.nixos.org/jobset/nixpkgs/haskell-updates confirm that everything still works as expected. 😁

@peti peti self-assigned this Dec 22, 2016
@LnL7 LnL7 removed the 2.status: work-in-progress This PR isn't done label Dec 22, 2016
@LnL7
Copy link
Member Author

LnL7 commented Dec 22, 2016

Great! I tested it locally for rocksdb, it's a bit of a hack but it should fix a whole bunch of packages until this is fixed properly upstream.

@LnL7
Copy link
Member Author

LnL7 commented Dec 24, 2016

Merged master at 19e2e72.

@LnL7 LnL7 closed this Dec 24, 2016
@LnL7 LnL7 deleted the darwin-haskell-dyld branch December 24, 2016 22:24
@LnL7
Copy link
Member Author

LnL7 commented Dec 26, 2016

I assumed that #16357 would also be fixed by this, but it looks like something still goes wrong during the checkPhase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: haskell
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants