Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib.teams.llvm: create #211401

Merged
merged 1 commit into from
Jan 22, 2023
Merged

lib.teams.llvm: create #211401

merged 1 commit into from
Jan 22, 2023

Conversation

sternenseemann
Copy link
Member

As a first stop towards getting a bit more organized for #171047, add a maintainer team and add myself and John Ericson as new members.

A second step could be creating a github team additionally.

cc @Ericson2314 @primeos @dtzWill @lovek323 @7c6f434c. LMK if anyone wants out.

@inclyc if you want to join, you'd need to do so in a follow up PR, as you have no entry in lib.maintainers yet, so it is difficult for me to include you.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@inclyc
Copy link
Member

inclyc commented Jan 18, 2023

if you want to join, you'd need to do so in a follow up PR, as you have no entry in lib.maintainers yet, so it is difficult for me to include you.

That's fine, I'm not weigh enough at this area.

A second step could be creating a github team additionally.

If there are LLVM-related issues, I hope to subscribe to them. After I am familiar enough in this area, I will submit a PR application to become a maintainer.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Jan 18, 2023
@rrbutani rrbutani mentioned this pull request Jan 18, 2023
92 tasks
@7c6f434c
Copy link
Member

7c6f434c commented Jan 20, 2023

I so sometimes merge things in the intersection of very unlikely to break stuff, no feedback from people who are actually competent, clear benefit; but I am not really up to date to what happens with LLVM or LLVM packaging, so maybe it's better to drop me.

ETA w/o spamming: Thanks!

As a first stop towards getting a bit more organized for NixOS#171047, add a
maintainer team and add myself and John Ericson as new members. Michael
Raskin asked to be removed.

A second step could be creating a github team additionally.
@sternenseemann
Copy link
Member Author

sternenseemann commented Jan 20, 2023

@7c6f434c done!

@sternenseemann sternenseemann merged commit eb4d3bc into NixOS:master Jan 22, 2023
@sternenseemann sternenseemann deleted the llvm-team branch January 22, 2023 00:28
@primeos
Copy link
Member

primeos commented Jan 22, 2023

Thanks a lot @sternenseemann and @Ericson2314 (also in general for your work on LLVM) and sorry for my late reply.
Definitely a +1 from me - this feels long overdue :)

I'll likely remove myself from the team after a while as I do currently lack the time to work on LLVM and don't have much to contribute to discussions but I'm still keeping a bit of an eye on LLVM changes/notifications (due to the importance for Chromium).

@github-actions
Copy link
Contributor

Successfully created backport PR for release-22.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants