python3Packages.yark: init at 1.2.3 #211269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By request, in NixOS#209237, but also it's been on my plate for about a week to investigate. I have tested that the main executable runs, but I haven't tried out any subcommands yet.
ofborg
bot
added
8.has: package (new)
|
Author of yark here, looks like a good contrib and the hash checks out
|
NickCao
reviewed
Jan 19, 2023
This was requested during code review.
NickCao
approved these changes
Jan 20, 2023
ajs124
reviewed
Jan 23, 2023
| meta = with lib; { | ||
| description = "YouTube archiving made simple"; | ||
| homepage = "https://github.com/Owez/yark"; | ||
| license = licenses.mit; |
There was a problem hiding this comment.
https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#submitting-changes requires meta.maintainers must be set.
There was a problem hiding this comment.
@MostAwesomeDude would you like to open a followup PR adding yourself as a maintainer?
|
A minor 1.2.4 change has been released also been released. Changes for a followup PR look to be:
The new version's hash (non-base64) is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By request, in #209237, but also it's been on my plate for about a week to investigate. Since many folks want this, I'm allowing edits to the PR so that we can get this merged as soon as everybody is happy.
I have tested that the main executable runs. I tested the following workflow, based on the upstream README:
Description of changes
yark is a YouTube archival tool. It saves metadata and videos from YouTube into archive-ready folders.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes