Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3.pkgs.sphinxcontrib-openapi: switch back to upstream #211156

Merged
merged 1 commit into from
Jan 17, 2023
Merged

python3.pkgs.sphinxcontrib-openapi: switch back to upstream #211156

merged 1 commit into from
Jan 17, 2023

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jan 16, 2023

Upstream incorporated the changes present in the cilium fork into their repository, and tagged a new release (0.8.0). We can switch back to the upstream version, rather than the temporary fork.

See #188280 (comment)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@flokli
python3.pkgs.sphinxcontrib-openapi: switch back to upstream
ca3e08f 
Upstream incorporated the changes present in the cilium fork into their
repository, and tagged a new release (0.8.0). We can switch back to the
upstream version, rather than the temporary fork.

See NixOS#188280 (comment)
@flokli flokli mentioned this pull request Jan 16, 2023
Merged
13 tasks
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 16, 2023
@flokli
Copy link
Contributor Author

flokli commented Jan 17, 2023

I successfully built some sphinx docs using openapi:httpdomain:: with this version monkey-patched in, so let's merge this :-)

@flokli flokli merged commit 856cf90 into NixOS:master Jan 17, 2023
@flokli flokli deleted the sphinxcontrib-openapi-bump branch January 17, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@flokli