-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bupstash, httm, rustpython: unbreak on x86_64-darwin #209065
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ACK (builds and runs on both x86_64-darwin and aarch64-darwin).
I think the selected approach is the best way how to fix Rust stuff on x86_64-darwin.
Build of
following an extremely long ld command |
I guess the length falls between And also, linking to the meta issue at #41340. |
@risicle Can you figure out how long is the command line? I am wondering whether we are tripping on ARG_MAX or stack size (ulimit -s). Not sure how is it on Darwin but SO says that "On Linux, the maximum amount of space for command arguments is 1/4th of the amount of available stack space. So, a solution is to increase the amount of space available for the stack." - from https://unix.stackexchange.com/a/45584 |
Was this closed because it's not needed anymore or another reason? |
I relaunched the PR in #214119 in a slightly different way, as I haven't got as many reviews to be sure to merge it. |
Description of changes
Maybe the approach in #180931 is more appropriate, but well, at least this fixes the builds...
@prusnak Would you like to take a look?
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes