Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nixos-enter: hide systemd-tmpfiles errors, extend test #208643

Merged
merged 2 commits into from
Jan 9, 2023
Merged

nixos/nixos-enter: hide systemd-tmpfiles errors, extend test #208643

merged 2 commits into from
Jan 9, 2023

Conversation

ncfavier
Copy link
Member

@ncfavier ncfavier commented Jan 1, 2023 •
edited
Loading

Following up on #80769 and #199425 by hiding the systemd-tmpfiles warnings (see below) and extending the installer test.

The test now fails without the systemd-tmpfiles call.

/etc/tmpfiles.d/journal-nocow.conf:26: Failed to replace specifiers in '/var/log/journal/%m': No such file or directory
/etc/tmpfiles.d/systemd.conf:23: Failed to replace specifiers in '/run/log/journal/%m': No such file or directory
/etc/tmpfiles.d/systemd.conf:25: Failed to replace specifiers in '/run/log/journal/%m': No such file or directory
/etc/tmpfiles.d/systemd.conf:26: Failed to replace specifiers in '/run/log/journal/%m/*.journal*': No such file or directory
/etc/tmpfiles.d/systemd.conf:29: Failed to replace specifiers in '/var/log/journal/%m': No such file or directory
/etc/tmpfiles.d/systemd.conf:30: Failed to replace specifiers in '/var/log/journal/%m/system.journal': No such file or directory
/etc/tmpfiles.d/systemd.conf:32: Failed to replace specifiers in '/var/log/journal/%m': No such file or directory
/etc/tmpfiles.d/systemd.conf:33: Failed to replace specifiers in '/var/log/journal/%m/system.journal': No such file or directory

@ncfavier
nixos/nixos-enter: hide systemd-tmpfiles errors
a5b7b6e 
Due to missing `/etc/machine-id` in the new root, systemd-tmpfiles
outputs a bunch of scary warnings like "Failed to replace specifiers in
'/run/log/journal/%m'". We only care about /tmp, so hide them.

`-E` is an alias for `--exclude-prefix=/dev --exclude-prefix=/proc
--exclude-prefix=/run --exclude-prefix=/sys`.
@ncfavier
nixos/tests/installer: test initrd secrets and nix-build
19cfb3e 
Both of those things rely on nixos-enter creating `/tmp` under the mount
point.
@ncfavier ncfavier requested review from nh2 and chkno January 1, 2023 16:24
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 1, 2023
@ncfavier ncfavier changed the title nixos/nixos-enter: hide systemd-tmpfiles errors nixos/nixos-enter: hide systemd-tmpfiles errors, extend test Jan 1, 2023
@ncfavier
Copy link
Member Author

ncfavier commented Jan 1, 2023 •
edited
Loading

@ofborg test installer

@ncfavier
Copy link
Member Author

ncfavier commented Jan 1, 2023

The four failing tests are already failing on Hydra.

@ncfavier ncfavier mentioned this pull request Jan 1, 2023
Closed
@ncfavier ncfavier merged commit b8ee437 into NixOS:master Jan 9, 2023
@ncfavier ncfavier deleted the installer-test-tmp branch January 9, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2 Awaiting requested review from nh2

@chkno chkno Awaiting requested review from chkno

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ncfavier