Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages: add overrideable withLibunwind #207325

Closed
wants to merge 1 commit into from
Closed

llvmPackages: add overrideable withLibunwind #207325

wants to merge 1 commit into from

Conversation

ehmry
Copy link
Contributor

@ehmry ehmry commented Dec 22, 2022

See #170850

@ehmry
llvmPackages: add overrideable withLibunwind
319626a 
This makes it possible to disable bundling libunwind with Clang
for out-of-tree platforms.
@ehmry ehmry requested a review from matthewbauer as a code owner December 22, 2022 20:33
@rrbutani rrbutani mentioned this pull request Dec 22, 2022
Merged
92 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 22, 2022
@ehmry ehmry mentioned this pull request Mar 11, 2023
Merged
12 tasks
@rrbutani rrbutani mentioned this pull request Mar 26, 2023
Closed
48 tasks
@AndersonTorres
Copy link
Member

Closing as dead, unmergeable shit

@rrbutani
Copy link
Contributor

@AndersonTorres why do you think this is dead/unmergable?

@ehmry
Copy link
Contributor Author

ehmry commented May 14, 2023

Whatever, llvmPackages is messy but if it works don't break it.

@AndersonTorres
Copy link
Member

AndersonTorres commented May 14, 2023 •
edited
Loading

@AndersonTorres why do you think this is dead/unmergable?

I don't think, it is: Github interface says this can't be merged because conflicts with current codebase.

Further, this PR is 5 months old.

@zimbatm
Copy link
Member

zimbatm commented Aug 4, 2023

@AndersonTorres please be more respectful of other people's work. This is the second time that one of your messages got reported to the moderation team. Please DM me if you have any questions.

@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ehmry @AndersonTorres @rrbutani @zimbatm