-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
portaudio: 19-20140130 -> 19-20161030 #20592
Conversation
@TravisWhitaker, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bluescreen303, @lovek323 and @bjornfor to be potential reviewers. |
@vcunat also a potential reviewer. |
The source hash wasn't changed! |
Meaning you most likely haven't tested building from the new source at all. |
Reverted for now. |
Oh dear, I did neglect to update the source hash. However, in my branch Can anyone else confirm this? |
@vcunat the build is tested and reverse dependencies pass tests, with the exception of |
It fetches the old source, as we employ hash-addressing to find cached sources on tarballs.nixos.org |
Meaning it builds (and tests) the old version. |
For prefetching sources I recommend
|
Ah, that explains it then. My apologies. For which derivations does tarballs.nixos.org cache the source? Typically if I forget to update the hash an error is generated. @vcunat thanks for the catch, and thanks for the |
It's not fully automatic (see e.g. #11782), but all default |
The mistake is relatively common; unfortunately I don't know a good way to prevent it from happening (meaning especially people who don't know about it). |
Oops. Don't know how I missed that, I did look. Oh, well |
Motivation for this change
Update.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)