-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc/lib-functions: remove warnings, add versions
, cli
#205643
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Please implement @roberth's suggestions.
@ncfavier good point about the ordering, that indeed eluded me. I'm skeptical about changing the order haphazardly, as it (implicitly, but still) tells readers of the TOC something about relative importance and can be used to guide their attention. Even if it's more cumbersome I'd prefer to instead pass the sections around as a list. @roberth what do you think? |
I don't think the ordering was particularly good, but I guess it works?
Seems a bit fanciful for independent pieces of reference documentation. Perhaps it may be helpful (for the TOC) to start the section names with |
People will still tend to attempt reading it back to back in lack of other resources, so we may as well not be in the way of finding the most relevant things first. |
Done, but nixdoc escapes |
Building the nixpkgs manual currently triggers a bunch of deprecation warnings, because every attribute in `lib` is evaluated to see if it's an attrset to generate locations for. Instead, share the lib subsets to include in the documentation between `lib-function-docs` and `lib-function-locations` so they can coordinate. Also generate the list of sections instead of duplicating it in `library.xml`.
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-42/24204/1 |
Building the nixpkgs manual currently triggers a bunch of deprecation warnings, because every attribute in
lib
is evaluated to see if it's an attrset to generate locations for.Instead, share the lib subsets to include in the documentation between
lib-function-docs
andlib-function-locations
so they can coordinate.I also wanted to add
modules
(the upcominglib.modules.typeCheck{,ing}
might especially be worth documenting) but there are several obstacles:nixdoc
generates documentation for non-toplevel local functions likecollectStructuredModules
(which then fail the build because they try to include location information that wasn't generated).Fixes #116472