Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy-boto3-*: init at 1.26.0.post1 #205103

Closed
wants to merge 1 commit into from
Closed

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented Dec 8, 2022

Description of changes

Motivation: #205083. Includes the following new packages:

  • mypy-boto3-batch
  • mypy-boto3-dynamodb
  • mypy-boto3-events
  • mypy-boto3-lambda
  • mypy-boto3-s3control
  • mypy-boto3-sns
  • mypy-boto3-sqs
  • mypy-boto3-ssm
  • mypy-boto3-stepfunctions
  • mypy-boto3-sts

@fabaff Are you OK to be listed as the maintainer of these, or should I instead add myself?

Things done
  • Built on platform(s)
    • x86_64-linux (nix-build nixos --attr pkgs.python39Packages.mypy-boto3-accessanalyzer --attr pkgs.python39Packages.mypy-boto3-account …)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 8, 2022

We need a very good reason to add those 300+ packages because it is nice to have it does not cut it here.

Also generating nix code with bash is not doing nix justice. We can generate those packages in a subset from json file in a tiny fraction of the code proposed here.

@l0b0 l0b0 force-pushed the feat/add-mypy-boto3 branch 2 times, most recently from a7a016a to 4c8798e Compare December 8, 2022 19:38
@l0b0
Copy link
Contributor Author

l0b0 commented Dec 8, 2022

We need a very good reason to add those 300+ packages because it is nice to have it does not cut it here.

OK, I've cut it down to just the ones I'm using, and which would help with replacing poetry2nix with just Nix in that project.

Also generating nix code with bash is not doing nix justice. We can generate those packages in a subset from json file in a tiny fraction of the code proposed here.

I've removed the offending script.

@SuperSandro2000
Copy link
Member

If you need packages for your projects the best solution would be to maintain in your repository. Then you have full control over them and we don't mass bump them and break your things.

Also I cannot recommend to replace pip, poetry and npm because nix uses them behind the back and for local development using them is way faster especially if you only want to try things.

@l0b0
Copy link
Contributor Author

l0b0 commented Dec 11, 2022

Thanks for the advice @SuperSandro2000! I'll take it into consideration, but managing multiple package managers in parallel is a huge pain compared to just relying on what's in nixpkgs. Also, by relying on nixpkgs I can get the pre-built packages from the caches, rather than building them myself.

@l0b0 l0b0 closed this Dec 11, 2022
@l0b0 l0b0 deleted the feat/add-mypy-boto3 branch December 11, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants