Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310Packages.metakernel: fix build #205043

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Conversation

skeuchel
Copy link
Contributor

@skeuchel skeuchel commented Dec 7, 2022

The package switched to hatch as the build backend in 0.29.2.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

The package switched to hatch as the build backend in 0.29.2.
Copy link
Contributor

@thomasjm thomasjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, if the CI passes then I'm happy. Thanks for fixing!

@onny
Copy link
Contributor

onny commented Dec 8, 2022

Result of nixpkgs-review pr 205043 run on x86_64-linux 1

2 packages built:
  • python310Packages.metakernel
  • python39Packages.metakernel

@onny onny merged commit ee2da11 into NixOS:master Dec 8, 2022
@onny
Copy link
Contributor

onny commented Dec 8, 2022

Thank you for fixing the package :)

@skeuchel skeuchel deleted the python-metakernel branch March 28, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants