haskellPackages.mkDerivation: Remove Darwin dynamic libraries workaround #203963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gabriella439
requested review from
cdepillabout,
sternenseemann and
maralorn
as code owners
The workaround that this change deletes was initially contributed in NixOS#25537 to mitigate NixOS#22810 until a more permanent solution could be devised. That more permanent solution was eventually contributed in NixOS#27536, which now obviates the initial workaround, so this change removes it.
Gabriella439
force-pushed
the
gabriella/remove_hack
branch
from
d555180 to
8ef469a
Compare
ofborg
bot
added
10.rebuild-darwin: 501+
10.rebuild-darwin: 5001+
10.rebuild-linux: 0
|
@matthewbauer explained out of band that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workaround that this change deletes was initially contributed in #25537 to mitigate #22810 until a more permanent solution could be devised. That more permanent solution was eventually contributed in #27536, which now obviates the initial workaround, so this change removes it.
I tested this on
aarch64-darwin(macOS Ventura 13.1) on our main internal project at work which has:enableSharedExecutables = true;… and everything built successfully without this work-around.
It may be possible that this succeeded because of my macOS version; specifically, the work-around might still be necessary for older versions of macOS for some reason that I'm not aware of. So keep that in mind when evaluating this PR.
Things done