-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yabai: 4.0.4 -> 5.0.2 #203504
yabai: 4.0.4 -> 5.0.2 #203504
Conversation
hey @IvarWithoutBones I would like to test it on my m1 mac, but I'm pretty new to nix. I'm using flakes and nix-darwin. Do I need to make an overlay to test it in my current environment? I already have the old yabai configured. |
Thanks for the quick response! The best way to test this would indeed be using an overlay, here is an example on how I would do that from a flake: {
inputs = {
# Use my fork of nixpkgs, with the commit fixed to the latest on this PRs branch
ivar-nixpkgs-yabai-5_0_1.url = "github:IvarWithoutBones/nixpkgs?rev=161530fa3434ea801419a8ca33dcd97ffb8e6fee";
};
outputs =
{ ivar-nixpkgs-yabai-5_0_1
}:
{
darwinConfigurations.foo = darwinSystem {
modules = [{
nixpkgs.overlays = [(self: super: {
yabai-5_0_1 = (import ivar-nixpkgs-yabai-5_0_1 { inherit (final) system; }).yabai;
})];
}];
};
};
} Then, your yabai configuration could set the services.yabai = {
enable = true;
package = pkgs.yabai-5_0_1;
}; |
looks like it's building and working fine, but the scripting addition doesn't seem to work. I don't get any errors or infinite dock restarted when I enable EDIT: scripting addition does seem to work aswell, it was my yabai config. 🥳 |
Could u update it to |
This removes the need for the yabai-load-sa script on x86_64-darwin, the scripting addition can now simply be installed/launched with `yabai --load-sa`.
161530f
to
27d6a8b
Compare
Thanks for letting me know about the new release, I've pushed an update to the derivation. As before it works fine on |
works fine on |
Using the overlay as well. Just switched over from managing this with homebrew and so far so good :D |
Backport failed for Please cherry-pick the changes locally. git fetch origin release-22.11
git worktree add -d .worktree/backport-203504-to-release-22.11 origin/release-22.11
cd .worktree/backport-203504-to-release-22.11
git checkout -b backport-203504-to-release-22.11
ancref=$(git merge-base d7e2c900d7330e3f748ec1239ba169691521563b 27d6a8b410d9e5280d6e76692156dce5d9d6ef86)
git cherry-pick -x $ancref..27d6a8b410d9e5280d6e76692156dce5d9d6ef86 |
This update removes the need for the
yabai-load-sa
script onx86_64-darwin
. The scripting addition can now simply be installed and launched withyabai --load-sa
, just like the official installation methods.I've used this only on
x86_64-darwin
where everything works as expected, testing onaarch64-darwin
would be appreciated.Note that the update is required for yabai to work on the new MacOS Ventura, so I suggest that it would be best to backport this PR to 21.11.
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes