Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rlaunch: fix build on aarch64-linux #203423

Merged
merged 1 commit into from
Nov 28, 2022
Merged

rlaunch: fix build on aarch64-linux #203423

merged 1 commit into from
Nov 28, 2022

Conversation

raphaelr
Copy link
Contributor

@raphaelr raphaelr commented Nov 28, 2022 •
edited
Loading

Description of changes

Fixes "error[E0308]: mismatched types; expected u8, found i8" on aarch64 (Log)

ZHF: #199919

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from danc86 November 28, 2022 09:17
@raphaelr
rlaunch: fix build on aarch64-linux
e48d21a 
Fixes "error[E0308]: mismatched types; expected `u8`, found `i8`" on aarch64
danc86
danc86 approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@danc86 danc86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@raphaelr
Copy link
Contributor Author

I've also just disabed the build on darwin because it's broken (patchelf not found, and I believe upstream only supports Linux anyway).

@ofborg ofborg bot requested a review from danc86 November 28, 2022 09:41
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Nov 28, 2022
@figsoda figsoda merged commit 3f1aa79 into NixOS:master Nov 28, 2022
@github-actions github-actions bot mentioned this pull request Nov 28, 2022
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR #203463 for release-22.11.

@raphaelr raphaelr deleted the rlaunch-aarch64 branch December 6, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@figsoda figsoda figsoda approved these changes

@danc86 danc86 Awaiting requested review from danc86

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raphaelr @danc86 @figsoda