Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpv: set pipewireSupport to false #201724

Closed
wants to merge 1 commit into from
Closed

mpv: set pipewireSupport to false #201724

wants to merge 1 commit into from

Conversation

AndersonTorres
Copy link
Member

Support is still experimental and a bit buggy.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Support is still experimental and a bit buggy.
@AndersonTorres
Copy link
Member Author

@OPNA2608 do this solve the problem you have found?

#201367 (comment)

@ofborg ofborg bot requested review from Ma27, tadeokondrak, globin and fpletz November 18, 2022 04:02
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Nov 18, 2022
@SuperSandro2000
Copy link
Member

Is this solved with pipewire 0.3.60 which is on staging-next right now? see mpv-player/mpv#10859 (comment)

If so I don't think we need to do anything here and just wait for the merge.

@AndersonTorres
Copy link
Member Author

That being said, I will close this. If anyone is interested, just reopen or even pick the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants