Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blocky: embed version info #200215

Merged
merged 2 commits into from
Nov 9, 2022
Merged

Conversation

bjornfor
Copy link
Contributor

@bjornfor bjornfor commented Nov 8, 2022

Description of changes

Before:

  $ blocky version
  [...]
  Version: undefined

After:

  $ blocky version
  [...]
  Version: 0.19
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Before:

  $ blocky version
  [...]
  Version: undefined

After:

  $ blocky version
  [...]
  Version: 0.19
@bjornfor bjornfor requested a review from ratsclub November 8, 2022 19:54
@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000 SuperSandro2000 merged commit 7f290a9 into NixOS:master Nov 9, 2022
@bjornfor bjornfor deleted the blocky-add-version branch November 9, 2022 16:58
rtimush pushed a commit to rtimush/nixpkgs that referenced this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants