boehmgc: explain+refine test-disablement on darwin #199980
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 172f9cf disabled the checks for boehmgc on darwin-x86_64 with the comment "`gctest` fails under emulation on aarch64-darwin". Presumably this is because the test does not work under Apple's Rosetta binary translator, which is used to execute x86_64 binaries on aarch64 hosts. The `check` phase would only use this translator if a narrower condition is met: ``` stdenv.isDarwin && stdenv.buildPlatform.isAarch64 && stdenv.hostPlatform.isx86_64 ``` Let's use that condition instead, mainly as documentation so people don't think that the boehm-gc test suite is unreliable (this happened already in #198591). The boehm-gc test suite is actually quite good, and it is extremely important to run the tests for this particular package because of the number of advanced conservative-collector techniques it uses. Malfunctions here can cause use-after-`free()` bugs that don't correspond to any particular invocation of `free()` the way they would in a C/C++ program. They are incredibly difficult to track down.
ghost
marked this pull request as draft
ghost
marked this pull request as ready for review
ofborg
bot
added
10.rebuild-darwin: 501+
10.rebuild-darwin: 5001+
10.rebuild-linux: 0
|
No, that won't work. The rosetta builds don't trigger |
|
If you want a narrower approach, disabling just the single test might be relatively easy. |
|
@vcunat I completely forgot that, as staging captain, your pre-release crunch period starts a month earlier. This can absolutely wait until after 22.11. PS, thanks for explaining how Rosetta is used in nixpkgs; that totally makes sense. |
|
It's not really in nixpkgs... but on Hydra, as x86 Apple HW would be less cost-effective. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Commit 172f9cf disabled the checks for boehmgc on darwin-x86_64 with the comment "
gctestfails under emulation on aarch64-darwin".Presumably this is because the test does not work under Apple's Rosetta binary translator, which is used to execute x86_64 binaries on aarch64 hosts. The
checkphase would only use this translator if a narrower condition is met:Let's use that condition instead, mainly as documentation so people don't think that the boehm-gc test suite is unreliable (this happened already in #198591). The boehm-gc test suite is actually quite good, and it is extremely important to run the tests for this particular package because of the number of advanced conservative-collector techniques it uses. Malfunctions here can cause use-after-
free()bugs that don't correspond to any particular invocation offree()the way they would in a C/C++ program. They are incredibly difficult to track down.CC: @zowoq @vcunat
#191339 (comment)
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes