Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epiphany #19917

Merged
merged 2 commits into from
Oct 27, 2016
Merged

Epiphany #19917

merged 2 commits into from
Oct 27, 2016

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Oct 27, 2016

Motivation for this change

#19884
https://lwn.net/Vulnerabilities/703983/

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc grahamc added 1.severity: security Issues which raise a security issue, or PRs that fix one 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 27, 2016
@mention-bot
Copy link

@grahamc, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DamienCassou, @groxxda and @sternenseemann to be potential reviewers.

@DamienCassou
Copy link
Contributor

Looks good to me.

@grahamc
Copy link
Member Author

grahamc commented Oct 27, 2016

@DamienCassou so Epiphany on release-16.09 needs this patch, but webkitgtk 2.14 doesn't exist in release-16.09. Think we should backport its creation too? Note: Epiphany now requires 2.14.

@DamienCassou
Copy link
Contributor

@grahamc I have no idea

@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants