Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metadata-cleaner: 2.2.3 -> 2.2.5 #198758

Merged
merged 1 commit into from
Nov 1, 2022
Merged

metadata-cleaner: 2.2.3 -> 2.2.5 #198758

merged 1 commit into from
Nov 1, 2022

Conversation

zendo
Copy link
Contributor

@zendo zendo commented Oct 31, 2022 •
edited by bobby285271
Loading

Description of changes

https://gitlab.com/rmnvgr/metadata-cleaner/-/releases
https://gitlab.com/rmnvgr/metadata-cleaner/-/compare/v2.2.3...v2.2.5

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from dotlambda October 31, 2022 08:40
@zendo zendo force-pushed the update-metadata-cleaner branch 2 times, most recently from 7c84978 to 3625177 Compare October 31, 2022 09:17
@fabaff
Copy link
Member

fabaff commented Oct 31, 2022

Result of nixpkgs-review pr 198758 run on x86_64-linux 1

1 package built:
  • metadata-cleaner

bobby285271
bobby285271 reviewed Oct 31, 2022
View reviewed changes
pkgs/applications/misc/metadata-cleaner/default.nix Outdated
gtk4
libadwaita
librsvg
poppler_gi
];

propagatedNativeBuildInputs = [
gobject-introspection
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is unclear to me why this needs to be propagated, I thought nativeBuildInputs should work already 🤔 #56943 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice that it can propagate self right now.

@zendo zendo force-pushed the update-metadata-cleaner branch from 3625177 to 63d2bf0 Compare October 31, 2022 15:23
@bobby285271 bobby285271 added the 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. label Nov 1, 2022
@bobby285271 bobby285271 merged commit 60426c0 into NixOS:master Nov 1, 2022
@zendo zendo deleted the update-metadata-cleaner branch November 1, 2022 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobby285271 bobby285271 bobby285271 left review comments

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zendo @fabaff @bobby285271