Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proxmox-backup-client: init at 2.2.1 #198676

Merged
merged 1 commit into from
Nov 2, 2022
Merged

proxmox-backup-client: init at 2.2.1 #198676

merged 1 commit into from
Nov 2, 2022

Conversation

cofob
Copy link
Member

@cofob cofob commented Oct 30, 2022

Description of changes

Closes #186282
Add proxmox-backup-client package.
Add new maintainer.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 30, 2022
@balsoft
Copy link
Member

balsoft commented Nov 1, 2022

What is the license on Cargo.lock ? Can you ask the copyright owners if they are OK with including it here verbatim?

@averyanalex
Copy link
Contributor

What is the license on Cargo.lock ? Can you ask the copyright owners if they are OK with including it here verbatim?

Source repository doesn't contain Cargo.lock. I generates it myself from patched Cargo.toml (if I remebered everything correctly)

@balsoft balsoft merged commit 23c102a into NixOS:master Nov 2, 2022
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balsoft balsoft balsoft approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proxmox-backup-client packaging request
4 participants
@cofob @balsoft @averyanalex @Janik-Haag