Fix texlive on darwin #19800
Merged
Fix texlive on darwin #19800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikesperber, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tohl, @edolstra and @vcunat to be potential reviewers. |
|
ping @vbgl @matthewbauer @LnL7 |
Mic92
added
6.topic: darwin
|
cc @acowley |
vcunat
reviewed
Oct 23, 2016
| ] | ||
| ++ stdenv.lib.optional stdenv.isLinux [ "bindings/glibc" "zlib" "wildcard" ] |
There was a problem hiding this comment.
optionals, please, to avoid nested lists.
Clisp depended on libffcall, which does not compile on Darwin. The dependency is optional though, so omit it on Darwin. Also, make conditional transitive dependencies on libffcall.
... as the build process invokes iconv.
|
Thanks for the review! Done. |
acowley
approved these changes
Oct 25, 2016
vcunat
added a commit
that referenced
this pull request
Oct 26, 2016
|
It's not perfect, apparently: #20062 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
texlive-2016 would not build on Darwin.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)