libtiff: patch for many CVEs #19710
Merged
libtiff: patch for many CVEs #19710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeQuissimus
reviewed
Oct 20, 2016
| @@ -1,4 +1,4 @@ | |||
| { stdenv, fetchurl, pkgconfig, zlib, libjpeg, xz }: | |||
| { stdenv, fetchurl, fetchpatch, pkgconfig, zlib, libjpeg, xz }: | |||
There was a problem hiding this comment.
Is fetchpatch new? I've never seen it used...
There was a problem hiding this comment.
Not super new. It basically normalizes then hashes patches to account for possible variations in patch autogeneration processes, like from GitHub.
|
LGTM, does this need a port to 16.09? |
NeQuissimus
added
1.severity: security
grahamc
added
the
9.needs: port to stable
grahamc
removed
the
9.needs: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://lwn.net/Vulnerabilities/703467/
#19678
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)